From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs
Date: Thu, 09 Oct 2008 06:19:56 +1100 [thread overview]
Message-ID: <1223493596.8157.80.camel@pasglop> (raw)
In-Reply-To: <ed82fe3e0810080828r115b3e85laf08e8d1e47faf42@mail.gmail.com>
On Wed, 2008-10-08 at 10:28 -0500, Timur Tabi wrote:
> On Fri, Sep 26, 2008 at 12:19 PM, Timur Tabi <timur@freescale.com> wrote:
> > The Kconfig files for PowerPC CHRP and PMAC support had "default=y" for some
> > Kconfig options, and this caused support for CHRP and PMAC platforms to be
> > enabled incorrectly for several platforms. Fix the Kconfigs and the
> > affected defconfigs.
>
> Ben,
>
> When you applied this patch, you removed the Kconfig changes. Without
> those, doing a "make xxx_defconfig" will just add "CONFIG_PPC_PMAC=y"
> and "CONFIG_PPC_CHRP=y" to the .config!
Hrm. Yes, I removed those changes because I want to think more about
that aspect of things.
> $ make 83xx/mpc834x_itxgp_defconfig
> HOSTCC scripts/basic/fixdep
> HOSTCC scripts/basic/docproc
> HOSTCC scripts/kconfig/conf.o
> HOSTCC scripts/kconfig/kxgettext.o
> SHIPPED scripts/kconfig/zconf.tab.c
> SHIPPED scripts/kconfig/lex.zconf.c
> SHIPPED scripts/kconfig/zconf.hash.c
> HOSTCC scripts/kconfig/zconf.tab.o
> HOSTLD scripts/kconfig/conf
> #
> # configuration written to .config
> #
> $ grep CHRP .config
> CONFIG_PPC_CHRP=y
>
> So please apply my *original* patch.
yeah well, there's a consistency problem. If we remove default for these
we should remove default for all.
The bug I think is in your original patch in fact to just remove those
from .config rather than explicitely set them to "not set".
I'm not going to remove the applied patch to avoid rebasing, it's
harmless to keep it in, please send another one that does the above.
Ben.
next prev parent reply other threads:[~2008-10-08 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 17:19 [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs Timur Tabi
2008-10-06 21:52 ` Timur Tabi
2008-10-08 15:28 ` Timur Tabi
2008-10-08 19:19 ` Benjamin Herrenschmidt [this message]
2008-10-08 19:22 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223493596.8157.80.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).