From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 75D15DDF76 for ; Thu, 9 Oct 2008 07:07:46 +1100 (EST) Subject: Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs From: Benjamin Herrenschmidt To: Timur Tabi In-Reply-To: <1223495845-14149-1-git-send-email-timur@freescale.com> References: <1223495845-14149-1-git-send-email-timur@freescale.com> Content-Type: text/plain Date: Thu, 09 Oct 2008 07:03:06 +1100 Message-Id: <1223496186.8157.82.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2008-10-08 at 14:57 -0500, Timur Tabi wrote: > Remove the "default y" from the Kconfig options for CHRP, PMAC, and PMAC64 > platforms. This patch is a follow-up to "remove CHRP and PMAC support from > defconfigs, fix Kconfigs", which was applied incompletely. No. Instead, send a patch that fixes the defconfig's to explicitely set those to "n". As to whether those should be defaults or not, this is a different discussion (I'm almost tempted to have everything default to y). Ben. > Signed-off-by: Timur Tabi > --- > > Ben, in the future, please apply either all of my patch or none of it. > Applying half of my patch and "thinking about" the other half doesn't do me > any good. > > arch/powerpc/platforms/chrp/Kconfig | 1 - > arch/powerpc/platforms/powermac/Kconfig | 4 ---- > 2 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/arch/powerpc/platforms/chrp/Kconfig b/arch/powerpc/platforms/chrp/Kconfig > index 22b4b4e..682afbc 100644 > --- a/arch/powerpc/platforms/chrp/Kconfig > +++ b/arch/powerpc/platforms/chrp/Kconfig > @@ -9,4 +9,3 @@ config PPC_CHRP > select PPC_UDBG_16550 > select PPC_NATIVE > select PCI > - default y > diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig > index 055990c..85619d3 100644 > --- a/arch/powerpc/platforms/powermac/Kconfig > +++ b/arch/powerpc/platforms/powermac/Kconfig > @@ -6,7 +6,6 @@ config PPC_PMAC > select PPC_INDIRECT_PCI if PPC32 > select PPC_MPC106 if PPC32 > select PPC_NATIVE > - default y > > config PPC_PMAC64 > bool > @@ -16,6 +15,3 @@ config PPC_PMAC64 > select MPIC_U3_HT_IRQS > select GENERIC_TBSYNC > select PPC_970_NAP > - default y > - > -