From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: avorontsov@ru.mvista.com
Cc: David Brownell <dbrownell@users.sourceforge.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Li Yang <leoli@freescale.com>, Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH 1/2 v2] OF: new helper: of_parse_phandles_with_args()
Date: Mon, 13 Oct 2008 10:31:23 +1100 [thread overview]
Message-ID: <1223854283.8157.202.camel@pasglop> (raw)
In-Reply-To: <20081010144317.GA2634@oksana.dev.rtsoft.ru>
On Fri, 2008-10-10 at 18:43 +0400, Anton Vorontsov wrote:
> The helper is factored out of of_get_gpio(). Will be used by the QE
> pin multiplexing functions (they need to parse the gpios = <> too).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> + while (list < list_end) {
> + const u32 *cells;
> + const phandle *phandle;
> +
> + phandle = list;
> + args = list + 1;
> +
> + /* one cell hole in the list = <>; */
> + if (!*phandle) {
> + list++;
> + goto next;
> + }
Allright. I'll merge it. It might have been nicer to write here
phandle = list++;
args = list;
if (!*phandle)
goto next;
.../...
list += *cells;
But it's not big deal, I'll merge it as-is and if you feel like it
you can aways submit a cleanup later. In fact you can even completely
drop "args" I think.
Cheers,
Ben.
next prev parent reply other threads:[~2008-10-13 0:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 18:36 [RFC PATCH 0/2] QE Pin Multiplexing API Anton Vorontsov
2008-09-25 18:37 ` [PATCH 1/2] OF: new helper: of_parse_phandles_with_args() Anton Vorontsov
2008-10-10 3:37 ` Benjamin Herrenschmidt
2008-10-10 14:43 ` [PATCH 1/2 v2] " Anton Vorontsov
2008-10-12 23:31 ` Benjamin Herrenschmidt [this message]
2008-09-25 18:37 ` [PATCH 2/2] powerpc/QE: implement QE Pin Multiplexing API Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223854283.8157.202.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).