linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linuxppc-dev@ozlabs.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH 1/2] powerpc: don't pass unused regs around in head_.*.S
Date: Tue, 14 Oct 2008 10:25:12 +1100	[thread overview]
Message-ID: <1223940312.8157.281.camel@pasglop> (raw)
In-Reply-To: <1223820494-7822-2-git-send-email-sebastian@breakpoint.cc>

On Sun, 2008-10-12 at 16:08 +0200, Sebastian Andrzej Siewior wrote:
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> This looks like a relict from arch/ppc. machine_init() is accepting
> only two parameters (dtb, phys) and is using only the first one.

This isn't 100% correct actually...

First, the base head_32.S (could be called head_6xx.S I suppose)
supports a few more calling conventions such as the real OF one, with
added support for initrd and cmdline in registers , and the BootX one.

Then, calling convention for the other cases is slightly better defined
than just having r3 contain a device-tree pointer. The physical address
is an important part of it, the fact that r5 is NULL to differenciate
from an OF entry too, and we're moving toward the full ePAPR definition.

Cheers,
Ben.

  reply	other threads:[~2008-10-13 23:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-12 14:08 Remove unused args in head_* Sebastian Andrzej Siewior
2008-10-12 14:08 ` [PATCH 1/2] powerpc: don't pass unused regs around in head_.*.S Sebastian Andrzej Siewior
2008-10-13 23:25   ` Benjamin Herrenschmidt [this message]
2008-10-14  9:08     ` Sebastian Andrzej Siewior
2008-10-12 14:08 ` [PATCH 2/2] powerpc: reflect the used arguments in machine_init() prototype Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223940312.8157.281.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=bigeasy@linutronix.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).