From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ayman El-Khashab <AymanE@tanisys.com>
Cc: linuxppc-dev@ozlabs.org
Subject: RE: Problems with PCI-E devices not being detected with switch
Date: Tue, 21 Oct 2008 09:55:19 +1100 [thread overview]
Message-ID: <1224543319.7654.180.camel@pasglop> (raw)
In-Reply-To: <16691A8B34B5D9458EA3A1C37A11555A0137F832@tanisys-ex2.Tanisys.Local>
> The part that didn't look correct is this line (note the operators)
>
> ((buses >> 8) & 0xff) != <= bus->number) {
>
> Operators ^^ ^^
Ooohhh ... nice typo :-) The right one is <=, thanks for catching this !
> >From reading through the code and your textual description of what was
> supposed to be happening, I went ahead and changed it to ...
>
> ((buses >> 8) & 0xff) != bus->number) {
>
> And this is the code that generated the results from my previous
> message.
Yeah, that's enough to catch most of the problems incuding yours.
Cheers,
Ben.
prev parent reply other threads:[~2008-10-20 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 15:47 Problems with PCI-E devices not being detected with switch Ayman El-Khashab
2008-10-16 5:20 ` Benjamin Herrenschmidt
2008-10-16 8:03 ` Stefan Roese
2008-10-16 8:29 ` Benjamin Herrenschmidt
2008-10-16 8:48 ` Stefan Roese
2008-10-16 8:58 ` Benjamin Herrenschmidt
2008-10-16 15:01 ` Ayman El-Khashab
2008-10-16 21:19 ` Benjamin Herrenschmidt
2008-10-17 0:10 ` Benjamin Herrenschmidt
2008-10-17 7:22 ` Stefan Roese
2008-10-17 14:54 ` Ayman El-Khashab
2008-10-17 21:05 ` Benjamin Herrenschmidt
2008-10-17 21:19 ` Benjamin Herrenschmidt
2008-10-20 21:03 ` Ayman El-Khashab
2008-10-20 21:57 ` Benjamin Herrenschmidt
2008-10-20 22:14 ` Ayman El-Khashab
2008-10-20 22:55 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224543319.7654.180.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=AymanE@tanisys.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).