From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jason Jin <Jason.jin@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Enable enhanced functions for 8536 TSEC
Date: Tue, 21 Oct 2008 10:54:35 +1100 [thread overview]
Message-ID: <1224546875.7654.198.camel@pasglop> (raw)
In-Reply-To: <1224149492-11204-1-git-send-email-Jason.jin@freescale.com>
On Thu, 2008-10-16 at 17:31 +0800, Jason Jin wrote:
> Signed-off-by: Jason Jin <Jason.jin@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8536ds.dts | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8536ds.dts b/arch/powerpc/boot/dts/mpc8536ds.dts
> index 93fdd99..dce2f65 100644
> --- a/arch/powerpc/boot/dts/mpc8536ds.dts
> +++ b/arch/powerpc/boot/dts/mpc8536ds.dts
> @@ -180,7 +180,7 @@
> enet0: ethernet@24000 {
> cell-index = <0>;
> device_type = "network";
> - model = "TSEC";
> + model = "eTSEC";
> compatible = "gianfar";
> reg = <0x24000 0x1000>;
> local-mac-address = [ 00 00 00 00 00 00 ];
While this works, this isn't quite "proper" use of the device-tree,
you should instead have something like
compatible="gianfar-eTSEC","gianfar" or something like that
Cheers,
Ben.
prev parent reply other threads:[~2008-10-20 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 9:31 [PATCH] Enable enhanced functions for 8536 TSEC Jason Jin
2008-10-20 14:46 ` Kumar Gala
2008-10-20 23:54 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224546875.7654.198.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Jason.jin@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).