From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "Michael Weiser" <michael@weiser.dinsnail.net>,
"Rogério Brito" <rbrito@ime.usp.br>,
linuxppc-dev@ozlabs.org, "Scott Wood" <scottwood@freescale.com>
Subject: Re: [PATCH] fix i2c on PPC linkstation / kurobox machines
Date: Fri, 24 Oct 2008 11:19:40 +1100 [thread overview]
Message-ID: <1224807581.7654.424.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.0810240059170.9657@axis700.grange>
On Fri, 2008-10-24 at 01:05 +0200, Guennadi Liakhovetski wrote:
> i2c is broken on linkstation / kurobox machines since at least 2.6.27. Fix
> it. Also remove CONFIG_SERIAL_OF_PLATFORM, which, if enabled, breaks the
> serial console after the "console handover: boot [udbg0] -> real [ttyS1]"
> message.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
You may want to use udbg_printf() to track down what's up. There's some
fishy code there indeed, what happens is that the legacy serial code
creates a platform device at boot time. Then, the of_serial attaches to
the device node for the same device and tries to register it. It's
supposed to "detect" that it's the same device but yeah, it may be
buggy, I've seen problems with it in the past, among others, I think it
can lose some state.
In the meantime, removing SERIAL_OF_PLATFORM is a good solution.
Ben.
next prev parent reply other threads:[~2008-10-24 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081022191650.GA11406@weiser.dinsnail.net>
[not found] ` <Pine.LNX.4.64.0810232029380.9657@axis700.grange>
[not found] ` <20081023213309.GA19777@weiser.dinsnail.net>
2008-10-23 23:05 ` [PATCH] fix i2c on PPC linkstation / kurobox machines Guennadi Liakhovetski
2008-10-24 0:19 ` Benjamin Herrenschmidt [this message]
2008-10-24 18:25 ` Guennadi Liakhovetski
2008-10-28 13:58 ` Kumar Gala
2008-10-28 14:06 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224807581.7654.424.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=g.liakhovetski@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@weiser.dinsnail.net \
--cc=rbrito@ime.usp.br \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).