From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Allocate resources for PHB DLPAR add
Date: Fri, 24 Oct 2008 18:51:35 +1100 [thread overview]
Message-ID: <1224834695.7654.435.camel@pasglop> (raw)
In-Reply-To: <49014A41.6040700@austin.ibm.com>
On Thu, 2008-10-23 at 23:08 -0500, Nathan Fontenot wrote:
> Resources for PHB's that are DLPAR added to a system are not acquired.
> Not having these resources allocated causes an oops during DLPAR
> remove of the PHB when we try to release non-existant resources.
>
> The patch appears a bit messy, this is mainly due to moving everything
> one tab to the left in the pcibios_allocate_bus_resources routine. The
> big functionality change in this routine is only that the
> list_for_each_entry() loop is pulled out and moved to the necessary
> calling routine.
>
> Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
>
> ---
Patch looks good.
I'll include it in the next batch hopefully along with a variant of
another patch I'm working on to fix other issues I found with our PCI
hotplug resource management.
Cheers,
Ben.
prev parent reply other threads:[~2008-10-24 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 4:08 [PATCH] Allocate resources for PHB DLPAR add Nathan Fontenot
2008-10-24 7:51 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224834695.7654.435.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nfont@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).