From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by ozlabs.org (Postfix) with ESMTP id C3C8ADDD04 for ; Wed, 29 Oct 2008 23:09:51 +1100 (EST) Received: by ey-out-2122.google.com with SMTP id 6so1354552eyi.15 for ; Wed, 29 Oct 2008 05:09:48 -0700 (PDT) Subject: Re: [PATCH] uninorth agp: don't mark module parameter __devinit From: Michel =?ISO-8859-1?Q?D=E4nzer?= To: Johannes Berg In-Reply-To: <1225246284.1369.31.camel@johannes.berg> References: <1225246284.1369.31.camel@johannes.berg> Content-Type: text/plain; charset=utf-8 Date: Wed, 29 Oct 2008 13:09:45 +0100 Message-Id: <1225282185.3546.376.camel@thor.sulgenrain.local> Mime-Version: 1.0 Cc: linuxppc-dev list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote: > A module parameter can possibly be shown via sysfs, which isn't a good > idea if the section has been removed, so remove the __devinit > annotation. Under what circumstances could it be shown in sysfs? -- Earthling Michel Dänzer | http://tungstengraphics.com Libre software enthusiast | Debian, X and DRI developer