From: "Michel Dänzer" <michel@tungstengraphics.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] uninorth agp: don't mark module parameter __devinit
Date: Wed, 29 Oct 2008 17:34:04 +0100 [thread overview]
Message-ID: <1225298044.3546.414.camel@thor.sulgenrain.local> (raw)
In-Reply-To: <1225282379.5439.11.camel@johannes.berg>
On Wed, 2008-10-29 at 13:12 +0100, Johannes Berg wrote:
> On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote:
> > On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote:
> > > A module parameter can possibly be shown via sysfs, which isn't a good
> > > idea if the section has been removed, so remove the __devinit
> > > annotation.
> >
> > Under what circumstances could it be shown in sysfs?
>
> Sorry, my mistake, I overlooked that it had 0 permission:
> module_param(aperture, charp, 0);
>
> otherwise it would of course be in sysfs.
>
> Can uninorth_fetch_size be marked __devinit then?
I'm not sure, and none of the other AGP backend drivers seems to do
so...
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
next prev parent reply other threads:[~2008-10-29 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 2:11 [PATCH] uninorth agp: don't mark module parameter __devinit Johannes Berg
2008-10-29 12:09 ` Michel Dänzer
2008-10-29 12:12 ` Johannes Berg
2008-10-29 16:34 ` Michel Dänzer [this message]
2008-10-30 8:45 ` Johannes Berg
2008-10-30 8:50 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225298044.3546.414.camel@thor.sulgenrain.local \
--to=michel@tungstengraphics.com \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).