* [PATCH] uninorth agp: don't mark module parameter __devinit
@ 2008-10-29 2:11 Johannes Berg
2008-10-29 12:09 ` Michel Dänzer
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2008-10-29 2:11 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list
A module parameter can possibly be shown via sysfs, which isn't a good
idea if the section has been removed, so remove the __devinit
annotation.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Also fixes a section mismatch warning.
--- everything.orig/drivers/char/agp/uninorth-agp.c 2008-10-29 03:07:26.000000000 +0100
+++ everything/drivers/char/agp/uninorth-agp.c 2008-10-29 03:08:16.000000000 +0100
@@ -27,7 +27,7 @@
static int uninorth_rev;
static int is_u3;
-static char __devinitdata *aperture = NULL;
+static char *aperture = NULL;
static int uninorth_fetch_size(void)
{
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] uninorth agp: don't mark module parameter __devinit
2008-10-29 2:11 [PATCH] uninorth agp: don't mark module parameter __devinit Johannes Berg
@ 2008-10-29 12:09 ` Michel Dänzer
2008-10-29 12:12 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Michel Dänzer @ 2008-10-29 12:09 UTC (permalink / raw)
To: Johannes Berg; +Cc: linuxppc-dev list
On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote:
> A module parameter can possibly be shown via sysfs, which isn't a good
> idea if the section has been removed, so remove the __devinit
> annotation.
Under what circumstances could it be shown in sysfs?
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] uninorth agp: don't mark module parameter __devinit
2008-10-29 12:09 ` Michel Dänzer
@ 2008-10-29 12:12 ` Johannes Berg
2008-10-29 16:34 ` Michel Dänzer
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2008-10-29 12:12 UTC (permalink / raw)
To: Michel Dänzer; +Cc: linuxppc-dev list
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote:
> On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote:
> > A module parameter can possibly be shown via sysfs, which isn't a good
> > idea if the section has been removed, so remove the __devinit
> > annotation.
>
> Under what circumstances could it be shown in sysfs?
Sorry, my mistake, I overlooked that it had 0 permission:
module_param(aperture, charp, 0);
otherwise it would of course be in sysfs.
Can uninorth_fetch_size be marked __devinit then?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] uninorth agp: don't mark module parameter __devinit
2008-10-29 12:12 ` Johannes Berg
@ 2008-10-29 16:34 ` Michel Dänzer
2008-10-30 8:45 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Michel Dänzer @ 2008-10-29 16:34 UTC (permalink / raw)
To: Johannes Berg; +Cc: linuxppc-dev list
On Wed, 2008-10-29 at 13:12 +0100, Johannes Berg wrote:
> On Wed, 2008-10-29 at 13:09 +0100, Michel Dänzer wrote:
> > On Wed, 2008-10-29 at 03:11 +0100, Johannes Berg wrote:
> > > A module parameter can possibly be shown via sysfs, which isn't a good
> > > idea if the section has been removed, so remove the __devinit
> > > annotation.
> >
> > Under what circumstances could it be shown in sysfs?
>
> Sorry, my mistake, I overlooked that it had 0 permission:
> module_param(aperture, charp, 0);
>
> otherwise it would of course be in sysfs.
>
> Can uninorth_fetch_size be marked __devinit then?
I'm not sure, and none of the other AGP backend drivers seems to do
so...
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] uninorth agp: don't mark module parameter __devinit
2008-10-29 16:34 ` Michel Dänzer
@ 2008-10-30 8:45 ` Johannes Berg
2008-10-30 8:50 ` Michel Dänzer
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Berg @ 2008-10-30 8:45 UTC (permalink / raw)
To: Michel Dänzer; +Cc: linuxppc-dev list
Michel Dänzer wrote:
>> Can uninorth_fetch_size be marked __devinit then?
>
> I'm not sure, and none of the other AGP backend drivers seems to do
> so...
Well, either it can, or marking "aperture" is wrong, no?
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] uninorth agp: don't mark module parameter __devinit
2008-10-30 8:45 ` Johannes Berg
@ 2008-10-30 8:50 ` Michel Dänzer
0 siblings, 0 replies; 6+ messages in thread
From: Michel Dänzer @ 2008-10-30 8:50 UTC (permalink / raw)
To: Johannes Berg; +Cc: linuxppc-dev list
On Thu, 2008-10-30 at 09:45 +0100, Johannes Berg wrote:
> Michel Dänzer wrote:
>
> >> Can uninorth_fetch_size be marked __devinit then?
> >
> > I'm not sure, and none of the other AGP backend drivers seems to do
> > so...
>
> Well, either it can, or marking "aperture" is wrong, no?
Makes sense, but I'm not sure about all the conditions and implications
involved.
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-10-30 8:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 2:11 [PATCH] uninorth agp: don't mark module parameter __devinit Johannes Berg
2008-10-29 12:09 ` Michel Dänzer
2008-10-29 12:12 ` Johannes Berg
2008-10-29 16:34 ` Michel Dänzer
2008-10-30 8:45 ` Johannes Berg
2008-10-30 8:50 ` Michel Dänzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).