linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, pauus@samba.org
Subject: Re: [PATCH] powerpc: remove unused variable from pci_dlpar.c
Date: Mon, 03 Nov 2008 18:26:33 +1100	[thread overview]
Message-ID: <1225697193.8004.241.camel@pasglop> (raw)
In-Reply-To: <20081103180712.0494af2b.sfr@canb.auug.org.au>

On Mon, 2008-11-03 at 18:07 +1100, Stephen Rothwell wrote:
> And get rid of this build warning:
> 
> arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
> arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
> 
> This is one of the very few warnings left in a ppc64_defconfig build and
> getting rid of it will make it easier to see future introduced ones (in
> fact this was introduced very recently).
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---

Ack.

>  arch/powerpc/platforms/pseries/pci_dlpar.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> This patch is against Linus' tree and so could go into 2.6.28 if you
> think it should.  This is also fixed by one of Ben's ominbus patches
> (http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
> upstream merge.
> 
> diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c b/arch/powerpc/platforms/pseries/pci_dlpar.c
> index 31481dc..7190493 100644
> --- a/arch/powerpc/platforms/pseries/pci_dlpar.c
> +++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
> @@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn)
>  {
>  	struct pci_controller *phb;
>  	int primary;
> -	struct pci_bus *b;
>  
>  	primary = list_empty(&hose_list);
>  	phb = pcibios_alloc_controller(dn);
> -- 
> 1.5.6.5
> 

  reply	other threads:[~2008-11-03  7:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-03  7:07 [PATCH] powerpc: remove unused variable from pci_dlpar.c Stephen Rothwell
2008-11-03  7:26 ` Benjamin Herrenschmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-11-03  7:18 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225697193.8004.241.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=pauus@samba.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).