LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] cell: fix ras.c compilation
Date: Mon, 03 Nov 2008 19:40:02 +1100	[thread overview]
Message-ID: <1225701602.3303.1.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0811030920310.11062@vixen.sonytel.be>

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Mon, 2008-11-03 at 09:20 +0100, Geert Uytterhoeven wrote:
> On Sun, 2 Nov 2008, Alexey Dobriyan wrote:
> > arch/powerpc/platforms/cell/ras.c:299: error: implicit declaration of function 'crash_shutdown_register'
> > 
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> > 
> >  arch/powerpc/platforms/cell/ras.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/arch/powerpc/platforms/cell/ras.c
> > +++ b/arch/powerpc/platforms/cell/ras.c
> > @@ -16,6 +16,7 @@
> >  #include <linux/kexec.h>
> >  #include <linux/crash_dump.h>
> >  
> > +#include <asm/kexec.h>
> 
> #include <linux/kexec.h>?

That struck me too. But the generic header only includes the arch one if
CONFIG_KEXEC=y, and this code needs things from asm/kexec.h even when it
=n. So I think this is the best fix.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-11-03  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-02 20:21 [PATCH] cell: fix ras.c compilation Alexey Dobriyan
2008-11-03  8:20 ` Geert Uytterhoeven
2008-11-03  8:40   ` Michael Ellerman [this message]
2008-11-03  8:55     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225701602.3303.1.camel@localhost \
    --to=michael@ellerman.id.au \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=adobriyan@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox