From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xes-mad.com (xes-mad.com [216.165.139.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 712C1DDE1E for ; Tue, 4 Nov 2008 05:57:06 +1100 (EST) Subject: Re: [PATCH] gianfar: Omit TBI auto-negotiation based on device tree From: Nate Case To: Trent Piepho In-Reply-To: References: <1225234382-23050-1-git-send-email-ncase@xes-inc.com> Content-Type: text/plain Date: Mon, 03 Nov 2008 12:55:32 -0600 Message-Id: <1225738532.27415.237.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Kumar Gala , Andy Fleming , netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2008-10-30 at 18:07 -0700, Trent Piepho wrote: > But more relevant to your serdes problem, I also have a patch that > prevents > restarting serdes auto-negotiation if the serdes link is already up. > My SGMII > PHY will auto-negotiate, but it takes about 3 seconds. Avoiding an > unnecessary 3 second auto-negotiation when the gianfar device is > opened lets > me cut my power-on to DHCP completion time in half. > > I wonder if this would also fix your problem, without needing to add > the extra > workaround? I just verified that your patch solves my problem without the need for my workaround. So at this point, it looks like we can drop this patch ("Omit TBI auto-negotiation based on device tree"). I tested when booting the kernel in U-Boot both via both TFTP and flash (I was worried that your patch may only fix things for the TFTP boot case, but that wasn't the case fortunately). Thanks for the patch! -- Nate Case