From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Linus Torvalds <torvalds@osdl.org>,
tglx@linutronix.de
Subject: Re: [PATCH 1/1] irq: Maintain user set affinity
Date: Sun, 09 Nov 2008 09:17:24 +1100 [thread overview]
Message-ID: <1226182645.13603.90.camel@pasglop> (raw)
In-Reply-To: <86802c440811081412u6d54beaam143801ce83225f40@mail.gmail.com>
On Sat, 2008-11-08 at 14:12 -0800, Yinghai Lu wrote:
> On Tue, Nov 4, 2008 at 8:31 AM, Kumar Gala <galak@kernel.crashing.org> wrote:
> > From 819ad3ed4660f4238e053728a8b5aa93d22b13d7 Mon Sep 17 00:00:00 2001
> > From: Kumar Gala <galak@kernel.crashing.org>
> > Date: Tue, 4 Nov 2008 10:13:53 -0600
> > Subject: [PATCH 1/1] irq: Maintain user set affinity
> >
> > This addresses a regression in that if a user specified an affinity
> > for an interrupt that affinity information would get reset between
> > a request_irq(), free_irq() and request_irq() for the same irq.
> >
> > On example of this is bringing up an ethernet interface, taking
> > it down and bringing it back up again.
> >
> > Instead of always using the irq_default_affinity we use the
> > previous setting of the IRQs affinity with the assumption that
> > at boot the IRQs affinity will be set to irq_default_affinity.
>
> why ?, the default_affinity is expected behavior...
>
> for example: when MSI is used, second driver could get same irq if
> first driver is unloaded.
The default affinity should be set when the irq is allocated / assigned
to a device, not when it's requested.
Ben.
next prev parent reply other threads:[~2008-11-08 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 16:31 [PATCH 1/1] irq: Maintain user set affinity Kumar Gala
2008-11-06 21:35 ` Andrew Morton
2008-11-06 23:23 ` Kumar Gala
2008-11-08 22:13 ` Yinghai Lu
2008-11-08 22:12 ` Yinghai Lu
2008-11-08 22:17 ` Benjamin Herrenschmidt [this message]
2008-11-09 0:01 ` Yinghai Lu
2008-11-09 2:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226182645.13603.90.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).