From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e36.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 0070CDDF53 for ; Wed, 12 Nov 2008 02:00:55 +1100 (EST) Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mABF0Ivs016953 for ; Tue, 11 Nov 2008 08:00:18 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mABF0ag3049544 for ; Tue, 11 Nov 2008 08:00:37 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mABF0YGM010144 for ; Tue, 11 Nov 2008 08:00:36 -0700 Subject: Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures. From: Hollis Blanchard To: Josh Boyer In-Reply-To: <20081111131937.GA2875@yoda.jdub.homelinux.org> References: <1224123753-20907-1-git-send-email-yanok@emcraft.com> <1224123753-20907-2-git-send-email-yanok@emcraft.com> <48FF3889.2030304@linux.vnet.ibm.com> <20081111131937.GA2875@yoda.jdub.homelinux.org> Content-Type: text/plain Date: Tue, 11 Nov 2008 09:00:23 -0600 Message-Id: <1226415623.458.6.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Wolfgang Denk , Ilya Yanok , linuxppc-dev@ozlabs.org, pvr@emcraft.com, dzu@denx.de List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2008-11-11 at 08:19 -0500, Josh Boyer wrote: > On Fri, Oct 31, 2008 at 06:23:28PM -0500, Hollis Blanchard wrote: > >On Wed, Oct 22, 2008 at 9:28 AM, Christian Ehrhardt > > wrote: > >> Hi Ilya, > >> I just tried your patch on my 440 board because it would help us in our > >> environment. > >> Unfortunately I run into a bug on early boot (mark_bootmem). > >> > >> A log can be found in this mail, this is the bug when running with 64k page > >> size. > >> I tried this with and without your 2/2 265k patch and also with page size > >> configured to 16k, the error is the same in all cases. > >> > >> I used an earlier version of your patch in the past and it worked fine. > >> Applying this old patch causes the same problem. > >> Therefore I expect that there was some other code changed that breaks with > >> page size != 4k. > > > >This patch seems to solve the problem for me, but I have to run and > >haven't yet worked out if it's the right fix. > > > >diff --git a/mm/bootmem.c b/mm/bootmem.c > >--- a/mm/bootmem.c > >+++ b/mm/bootmem.c > >@@ -300,7 +300,7 @@ static int __init mark_bootmem(unsigned > > unsigned long max; > > > > if (pos < bdata->node_min_pfn || > >- pos >= bdata->node_low_pfn) { > >+ pos > bdata->node_low_pfn) { > > BUG_ON(pos != start); > > continue; > > } > >@@ -399,7 +399,7 @@ int __init reserve_bootmem(unsigned long > > unsigned long start, end; > > > > start = PFN_DOWN(addr); > >- end = PFN_UP(addr + size); > >+ end = PFN_DOWN(addr + size); > > > > return mark_bootmem(start, end, 1, flags); > > } > > > Hollis, if I'm understanding things correctly this patch is no > longer needed if we do the memory reserve in the boot wrapper for > the errata. Correct? Correct. -- Hollis Blanchard IBM Linux Technology Center