From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/4] Use of_find_node_with_property() in pmac_setup_arch()
Date: Thu, 13 Nov 2008 20:27:25 +1100 [thread overview]
Message-ID: <1226568445.7178.47.camel@pasglop> (raw)
In-Reply-To: <cf9d9fddba10efbfd006706d6c5e2e201ff80c67.1226550015.git.michael@ellerman.id.au>
On Thu, 2008-11-13 at 15:20 +1100, Michael Ellerman wrote:
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
> ---
> arch/powerpc/platforms/powermac/setup.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
> index 82c14d2..1293772 100644
> --- a/arch/powerpc/platforms/powermac/setup.c
> +++ b/arch/powerpc/platforms/powermac/setup.c
> @@ -310,9 +310,7 @@ static void __init pmac_setup_arch(void)
> }
>
> /* See if newworld or oldworld */
> - for (ic = NULL; (ic = of_find_all_nodes(ic)) != NULL; )
> - if (of_get_property(ic, "interrupt-controller", NULL))
> - break;
> + ic = of_find_node_with_property(NULL, "interrupt-controller");
> if (ic) {
> pmac_newworld = 1;
> of_node_put(ic);
next prev parent reply other threads:[~2008-11-13 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 4:20 [PATCH 1/4] Add helpers for finding a device node which as a certain property Michael Ellerman
2008-11-13 4:20 ` [PATCH 2/4] Use for_each_node_with_property() in of_irq_map_init() Michael Ellerman
2008-11-13 4:20 ` [PATCH 3/4] Use of_find_node_with_property() in cell_iommu_fixed_mapping_init() Michael Ellerman
2008-11-13 4:20 ` [PATCH 4/4] Use of_find_node_with_property() in pmac_setup_arch() Michael Ellerman
2008-11-13 9:27 ` Benjamin Herrenschmidt [this message]
2008-11-13 6:46 ` [PATCH 1/4] Add helpers for finding a device node which as a certain property David Miller
2008-11-13 6:49 ` Michael Ellerman
2008-11-13 7:11 ` Michael Ellerman
2008-11-13 7:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226568445.7178.47.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).