* [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()
@ 2008-11-19 14:39 Kumar Gala
2008-11-20 4:46 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2008-11-19 14:39 UTC (permalink / raw)
To: linuxppc-dev
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
arch/powerpc/kernel/process.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 957bded..b038323 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -467,6 +467,8 @@ static struct regbit {
{MSR_VEC, "VEC"},
{MSR_VSX, "VSX"},
{MSR_ME, "ME"},
+ {MSR_CE, "CE"},
+ {MSR_DE, "DE"},
{MSR_IR, "IR"},
{MSR_DR, "DR"},
{0, NULL}
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()
2008-11-19 14:39 [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs() Kumar Gala
@ 2008-11-20 4:46 ` Benjamin Herrenschmidt
2008-11-20 15:31 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-11-20 4:46 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Wed, 2008-11-19 at 08:39 -0600, Kumar Gala wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
Shouldn't this be protected by some ifdef ?
Ben.
> arch/powerpc/kernel/process.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 957bded..b038323 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -467,6 +467,8 @@ static struct regbit {
> {MSR_VEC, "VEC"},
> {MSR_VSX, "VSX"},
> {MSR_ME, "ME"},
> + {MSR_CE, "CE"},
> + {MSR_DE, "DE"},
> {MSR_IR, "IR"},
> {MSR_DR, "DR"},
> {0, NULL}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs()
2008-11-20 4:46 ` Benjamin Herrenschmidt
@ 2008-11-20 15:31 ` Kumar Gala
0 siblings, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2008-11-20 15:31 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
On Nov 19, 2008, at 10:46 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2008-11-19 at 08:39 -0600, Kumar Gala wrote:
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>
> Shouldn't this be protected by some ifdef ?
>
> Ben.
>
>> arch/powerpc/kernel/process.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/
>> process.c
>> index 957bded..b038323 100644
>> --- a/arch/powerpc/kernel/process.c
>> +++ b/arch/powerpc/kernel/process.c
>> @@ -467,6 +467,8 @@ static struct regbit {
>> {MSR_VEC, "VEC"},
>> {MSR_VSX, "VSX"},
>> {MSR_ME, "ME"},
>> + {MSR_CE, "CE"},
>> + {MSR_DE, "DE"},
>> {MSR_IR, "IR"},
>> {MSR_DR, "DR"},
>> {0, NULL}
Why? The bits are always defined and don't seem to be reused (and we
don't ifdef VEC, VSX, etc..) so why bother?
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-20 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-19 14:39 [PATCH] powerpc: Add MSR[CE, DE] to the MSR bits we print on show_regs() Kumar Gala
2008-11-20 4:46 ` Benjamin Herrenschmidt
2008-11-20 15:31 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).