From: Michael Ellerman <michael@ellerman.id.au>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Joachim Fenkes <fenkes@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
OF-EWG <ewg@lists.openfabrics.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
OF-General <general@lists.openfabrics.org>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH] IB/ehca: Fix lockdep failures for shca_list_lock
Date: Sat, 22 Nov 2008 14:41:08 +1100 [thread overview]
Message-ID: <1227325268.10134.2.camel@localhost> (raw)
In-Reply-To: <1227283347.3599.8.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On Fri, 2008-11-21 at 17:02 +0100, Johannes Berg wrote:
> On Fri, 2008-11-21 at 16:37 +0100, Joachim Fenkes wrote:
>
> > + u64 flags;
>
> > - spin_lock(&shca_list_lock);
> > + spin_lock_irqsave(&shca_list_lock, flags);
>
> That's wrong and I think will give a warning on all machines where
> u64 != unsigned long. Might not particularly matter in this case.
Crud, sorry.
> Also, generally it seems wrong to say "fix lockdep failure" when the
> patch really fixes a bug that lockdep happened to find.
True. I guess it should be "fix locking error found with lockdep", to
make it clear no one has actually hit the bug.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-22 3:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 16:35 IB/ehca: Reject send WRs only for RESET, INIT and RTR state Joachim Fenkes
2008-06-06 18:22 ` Roland Dreier
2008-06-06 20:20 ` [ofa-general] " Dotan Barak
2008-06-09 11:24 ` [PATCH] IB/ehca: Reject recv WRs if QP is in RESET state Joachim Fenkes
2008-06-20 17:26 ` Roland Dreier
2008-07-01 14:14 ` [PATCH] IB/ehca: Make device table externally visible Joachim Fenkes
2008-07-01 17:55 ` Roland Dreier
2008-11-07 16:42 ` [PATCH] IB/ehca: Fix suppression of port activation events Joachim Fenkes
2008-11-10 20:36 ` Roland Dreier
2008-11-11 9:04 ` Joachim Fenkes
2008-11-21 15:37 ` [PATCH] IB/ehca: Fix lockdep failures for shca_list_lock Joachim Fenkes
2008-11-21 16:02 ` Johannes Berg
2008-11-21 16:18 ` [PATCH] IB/ehca: Fix locking " Joachim Fenkes
2008-11-21 18:28 ` Roland Dreier
2008-11-22 3:41 ` Michael Ellerman [this message]
2008-11-25 12:58 ` [PATCH] IB/ehca: Change misleading error message Joachim Fenkes
2008-11-25 23:13 ` Roland Dreier
2008-11-26 13:44 ` Joachim Fenkes
2009-06-03 14:28 ` [PATCH] IB/ehca: Remove superfluous bitmasks from QP control block Joachim Fenkes
2009-06-03 20:26 ` Roland Dreier
2009-09-01 11:55 ` [PATCH] IB/ehca: Fix CQE flags reporting Joachim Fenkes
2009-09-01 19:55 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227325268.10134.2.camel@localhost \
--to=michael@ellerman.id.au \
--cc=ewg@lists.openfabrics.org \
--cc=fenkes@de.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).