From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/32] rackmeter section fixes
Date: Sun, 23 Nov 2008 08:52:00 +1100 [thread overview]
Message-ID: <1227390720.7185.276.camel@pasglop> (raw)
In-Reply-To: <E1L3wOC-0006T5-Ji@ZenIV.linux.org.uk>
On Sat, 2008-11-22 at 17:35 +0000, Al Viro wrote:
> * rackmeter_remove() reference needs devexit_p
> * rackmeter_setup() is calls devinit and is called only from devinit
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> drivers/macintosh/rack-meter.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c
> --- a/drivers/macintosh/rack-meter.c
> +++ b/drivers/macintosh/rack-meter.c
> @@ -288,7 +288,7 @@ static void __devexit rackmeter_stop_cpu_sniffer(struct rackmeter *rm)
> cancel_rearming_delayed_work(&rm->cpu[1].sniffer);
> }
>
> -static int rackmeter_setup(struct rackmeter *rm)
> +static int __devinit rackmeter_setup(struct rackmeter *rm)
> {
> pr_debug("rackmeter: setting up i2s..\n");
> rackmeter_setup_i2s(rm);
> @@ -582,12 +582,12 @@ static struct of_device_id rackmeter_match[] = {
> { }
> };
>
> -static struct macio_driver rackmeter_drv = {
> +static struct macio_driver rackmeter_driver = {
> .name = "rackmeter",
> .owner = THIS_MODULE,
> .match_table = rackmeter_match,
> .probe = rackmeter_probe,
> - .remove = rackmeter_remove,
> + .remove = __devexit_p(rackmeter_remove),
> .shutdown = rackmeter_shutdown,
> };
>
> @@ -596,14 +596,14 @@ static int __init rackmeter_init(void)
> {
> pr_debug("rackmeter_init()\n");
>
> - return macio_register_driver(&rackmeter_drv);
> + return macio_register_driver(&rackmeter_driver);
> }
>
> static void __exit rackmeter_exit(void)
> {
> pr_debug("rackmeter_exit()\n");
>
> - macio_unregister_driver(&rackmeter_drv);
> + macio_unregister_driver(&rackmeter_driver);
> }
>
> module_init(rackmeter_init);
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
prev parent reply other threads:[~2008-11-22 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 17:35 [PATCH 13/32] rackmeter section fixes Al Viro
2008-11-22 21:52 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227390720.7185.276.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox