From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yuri Tikhonov <yur@emcraft.com>
Cc: sathya.prakash@lsi.com, Wolfgang Denk <wd@denx.de>,
Detlev Zundel <dzu@denx.de>,
linuxppc-dev@ozlabs.org, Ilya Yanok <yanok@emcraft.com>,
Eric.Moore@lsi.com
Subject: Re: Re[6]: [PATCH] katmai.dts: extend DMA ranges; add dma/sysace nodes
Date: Thu, 27 Nov 2008 15:07:41 +1100 [thread overview]
Message-ID: <1227758861.7356.19.camel@pasglop> (raw)
In-Reply-To: <8310162146.20081127035949@emcraft.com>
> > Strange... when I look at pci4xx_parse_dma_ranges() I see it
> > specifically avoiding PCI addresses above 4G ... That needs fixing.
>
> Right, it avoid. I guess you haven't read my e-mail to its end,
> because my work-around patch, which I referenced there, fixes this :)
Ooops, I though I did :-)
> Sure. The problem here is that the LSI (the PCI device I want to DMA
> to/from 1TB PCI addresses) driver doesn't work with this (i.e. it's
> broken in, e.g., 2.6.28-rc6) on ppc440spe-based platform. It looks
> like there is no support for 32-bit CPUs with 64-bit physical
> addresses in the LSI driver. E.g. the following mix in the
> drivers/message/fusion/mptbase.h code points to the fact that the
> driver supposes 64-bit dma_addr_t on 64-bit CPUs only:
>
> #ifdef CONFIG_64BIT
> #define CAST_U32_TO_PTR(x) ((void *)(u64)x)
> #define CAST_PTR_TO_U32(x) ((u32)(u64)x)
> #else
> #define CAST_U32_TO_PTR(x) ((void *)x)
> #define CAST_PTR_TO_U32(x) ((u32)x)
> #endif
>
>
> #define mpt_addr_size() \
> ((sizeof(dma_addr_t) == sizeof(u64)) ? MPI_SGE_FLAGS_64_BIT_ADDRESSING : \
> MPI_SGE_FLAGS_32_BIT_ADDRESSING)
>
So far I don't see anything in this that hints about that brokenness...
not that it's not there, but the above macros seem unrelated.
Cheers,
Ben.
> Regards, Yuri
>
> --
> Yuri Tikhonov, Senior Software Engineer
> Emcraft Systems, www.emcraft.com
next prev parent reply other threads:[~2008-11-27 4:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 8:49 [PATCH] katmai.dts: extend DMA ranges; add dma/sysace nodes Yuri Tikhonov
2008-11-13 9:25 ` Benjamin Herrenschmidt
2008-11-14 4:45 ` Re[2]: " Yuri Tikhonov
2008-11-14 5:41 ` Benjamin Herrenschmidt
[not found] ` <1767195957.20081127032002@emcraft.com>
2008-11-27 0:26 ` Re[4]: " Yuri Tikhonov
2008-11-27 0:42 ` Benjamin Herrenschmidt
2008-11-27 0:59 ` Re[6]: " Yuri Tikhonov
2008-11-27 4:07 ` Benjamin Herrenschmidt [this message]
2008-11-13 11:45 ` Josh Boyer
2008-11-14 5:00 ` Grant Likely
2008-11-14 5:27 ` Re[2]: " Yuri Tikhonov
2008-11-14 5:30 ` Grant Likely
2008-11-14 5:21 ` Yuri Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227758861.7356.19.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Eric.Moore@lsi.com \
--cc=dzu@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=sathya.prakash@lsi.com \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).