From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors
Date: Tue, 02 Dec 2008 20:20:41 +1100 [thread overview]
Message-ID: <1228209641.7356.176.camel@pasglop> (raw)
In-Reply-To: <BD75FAE9-7D10-488B-9906-23B2D93F1FB6@kernel.crashing.org>
On Tue, 2008-12-02 at 01:36 -0600, Kumar Gala wrote:
> > #define CPU_FTRS_E200 (CPU_FTR_USE_TB | CPU_FTR_SPE_COMP | \
> > CPU_FTR_NODSISRALIGN | CPU_FTR_COHERENT_ICACHE | \
> > - CPU_FTR_UNIFIED_ID_CACHE)
> > + CPU_FTR_UNIFIED_ID_CACHE | CPU_FTR_NOEXECUTE)
> > #define CPU_FTRS_E500 (CPU_FTR_MAYBE_CAN_DOZE | CPU_FTR_USE_TB | \
> > - CPU_FTR_SPE_COMP | CPU_FTR_MAYBE_CAN_NAP | CPU_FTR_NODSISRALIGN)
> > + CPU_FTR_SPE_COMP | CPU_FTR_MAYBE_CAN_NAP |
> > CPU_FTR_NODSISRALIGN \
>
> Added a '|' at the end of the line before the escape
Right. Will send a new patch tomorrow. Appart from that, have you
verified it doesn't have any adverse effects for you ? I did some quick
tests on 440 and things seem to be fine.
Cheers,
Ben.
next prev parent reply other threads:[~2008-12-02 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 6:01 [PATCH] powerpc: Fix bogus cache flushing on all 40x and BookE processors Benjamin Herrenschmidt
2008-12-02 7:36 ` Kumar Gala
2008-12-02 9:20 ` Benjamin Herrenschmidt [this message]
2008-12-03 23:09 ` Trent Piepho
2008-12-04 0:06 ` Benjamin Herrenschmidt
2008-12-02 15:41 ` Steven A. Falco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228209641.7356.176.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).