From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, Linus Torvalds <torvalds@osdl.org>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][for 2.6.28] powerpc: Use physical cpu id when setting the processor affinity
Date: Wed, 03 Dec 2008 08:30:23 +1100 [thread overview]
Message-ID: <1228253423.7356.195.camel@pasglop> (raw)
In-Reply-To: <1228246621-25622-1-git-send-email-galak@kernel.crashing.org>
On Tue, 2008-12-02 at 13:37 -0600, Kumar Gala wrote:
> In the CONFIG_SMP case the irq_choose_cpu() code was returning back
> a logical cpu id not the physical id. We were writing that directly
> into the HW register.
>
> We need to be calling get_hard_smp_processor_id() so irq_choose_cpu()
> always returns a physical cpu id.
That will probably do for now but if we ever move that routine to
generic code, I'd rather have the caller do the conversion.
Cheers,
Ben.
next prev parent reply other threads:[~2008-12-02 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 19:37 [PATCH][for 2.6.28] powerpc: Use physical cpu id when setting the processor affinity Kumar Gala
2008-12-02 21:30 ` Benjamin Herrenschmidt [this message]
2008-12-02 23:05 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228253423.7356.195.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).