linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: herbert@gondor.apana.org.au
Cc: linuxppc-dev@ozlabs.org, linux-crypto@vger.kernel.org
Subject: [PATCH] crypto: talitos - Fix modpost warning
Date: Tue,  2 Dec 2008 22:29:16 -0600	[thread overview]
Message-ID: <1228278556-1056-1-git-send-email-galak@kernel.crashing.org> (raw)

Removed __devexit from talitos_remove() since its also called from
talitos_probe().

WARNING: vmlinux.o(.text+0x28a008): Section mismatch in reference from the function talitos_probe() to the function .devexit.text:talitos_remove()
The function talitos_probe() references a function in an exit section.
Often the function talitos_remove() has valid usage outside the exit section
and the fix is to remove the __devexit annotation of talitos_remove.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 drivers/crypto/talitos.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index b6ad3ac..2479348 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1357,7 +1357,7 @@ static int hw_supports(struct device *dev, __be32 desc_hdr_template)
 	return ret;
 }
 
-static int __devexit talitos_remove(struct of_device *ofdev)
+static int talitos_remove(struct of_device *ofdev)
 {
 	struct device *dev = &ofdev->dev;
 	struct talitos_private *priv = dev_get_drvdata(dev);
-- 
1.5.6.5

             reply	other threads:[~2008-12-03  4:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03  4:29 Kumar Gala [this message]
2008-12-03 12:06 ` [PATCH] crypto: talitos - Fix modpost warning Herbert Xu
2008-12-03 14:52   ` Kumar Gala
2008-12-03 15:36     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228278556-1056-1-git-send-email-galak@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).