* [PATCH] Set the fsl elbc ECCM according the settings in bootloader.
@ 2008-12-08 3:41 Jason Jin
2008-12-08 16:39 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Jason Jin @ 2008-12-08 3:41 UTC (permalink / raw)
To: galak; +Cc: scottwood, linuxppc-dev, Jason Jin
The ECCM maybe set in bootloader, Get ECCM settings from the bootloader,
can avoid the image written by bootloader cannot read out by kernel.
But the limitation of doing it this way is that, it could break large page
NAND if it is written with NAND disabled in u-boot and read with NAND
enabled, or vice versa.
Signed-off-by: Jason Jin <Jason.jin@freescale.com>
---
drivers/mtd/nand/fsl_elbc_nand.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 4aa5bd6..65929db 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -777,7 +777,9 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv)
/* Fill in fsl_elbc_mtd structure */
priv->mtd.priv = chip;
priv->mtd.owner = THIS_MODULE;
- priv->fmr = 0; /* rest filled in later */
+
+ /* Set the ECCM according to the settings in bootloader.*/
+ priv->fmr = in_be32(&lbc->fmr) & FMR_ECCM;
/* fill in nand_chip structure */
/* set up function call table */
--
1.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Set the fsl elbc ECCM according the settings in bootloader.
2008-12-08 3:41 [PATCH] Set the fsl elbc ECCM according the settings in bootloader Jason Jin
@ 2008-12-08 16:39 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2008-12-08 16:39 UTC (permalink / raw)
To: Jason Jin; +Cc: linuxppc-dev
On Mon, Dec 08, 2008 at 11:41:03AM +0800, Jason Jin wrote:
> The ECCM maybe set in bootloader, Get ECCM settings from the bootloader,
> can avoid the image written by bootloader cannot read out by kernel.
>
> But the limitation of doing it this way is that, it could break large page
> NAND if it is written with NAND disabled in u-boot and read with NAND
> enabled, or vice versa.
>
> Signed-off-by: Jason Jin <Jason.jin@freescale.com>
Acked-by: Scott Wood <scottwood@freescale.com>
Please send to David Woodhouse and the linux-mtd list.
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-08 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-08 3:41 [PATCH] Set the fsl elbc ECCM according the settings in bootloader Jason Jin
2008-12-08 16:39 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).