From: Michael Ellerman <michael@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Kumar Gala <kumar.gala@freescale.com>
Subject: Re: [PATCH] powerpc: Introduce MMU features v2
Date: Tue, 09 Dec 2008 17:54:56 +1100 [thread overview]
Message-ID: <1228805696.17726.24.camel@localhost> (raw)
In-Reply-To: <20081209064732.D1904DDF15@ozlabs.org>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Tue, 2008-12-09 at 17:46 +1100, Benjamin Herrenschmidt wrote:
> We're soon running out of CPU features and I need to add some new
> ones for various MMU related bits, so this patch separates the MMU
> features from the CPU features. I moved over the 32-bit MMU related
> ones, added base features for MMU type families, but didn't move
> over any 64-bit only feature yet.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Remove a spurrious character that broke 64-bit build
>
> arch/powerpc/include/asm/cputable.h | 85 +++++++++-------------
> arch/powerpc/include/asm/feature-fixups.h | 30 +++++++
You forgot to add tests of the feature fixup macros :)
See the bottom of arch/powerpc/lib/feature-fixup-test.S, it should only
require two lines.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-12-09 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 6:46 [PATCH] powerpc: Introduce MMU features v2 Benjamin Herrenschmidt
2008-12-09 6:54 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228805696.17726.24.camel@localhost \
--to=michael@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).