powerbook VT garbled between rc7 and rc8

powerbook VT garbled between rc7 and rc8

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi,

After upgrading to -rc8 yesterday my powerbook started up today with the
screen totally garbled, only occasionally was a word readable. I also
tried adding radeonfb=accel_cexp to the command line but that changed
nothing. Also, once I was in X, it seemingly worked fine, but then I
opened up a terminal and tried setting the boot volume to 0 (nvsetvol 0)
[I had booted OSX yesterday] and the machine simply shut down and reset
its clock.

Something's amiss, but I have no idea what yet, and don't have time to
further diagnose/bisect before the end of next week.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: powerbook VT garbled between rc7 and rc8

[Andreas Schwab]

Johannes Berg <johannes@sipsolutions.net> writes:

> After upgrading to -rc8 yesterday my powerbook started up today with the
> screen totally garbled, only occasionally was a word readable.

Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
accelerate imageblit and other improvements").

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: powerbook VT garbled between rc7 and rc8

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > After upgrading to -rc8 yesterday my powerbook started up today with the
> > screen totally garbled, only occasionally was a word readable.
> 
> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
> accelerate imageblit and other improvements").

That's post -rc8, ok, but -rc7 worked fine here, and the stuff it
reverts is all pre -rc7, no? Strange. I'll try later.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: powerbook VT garbled between rc7 and rc8

[Andreas Schwab]

Johannes Berg <johannes@sipsolutions.net> writes:

> On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>> 
>> > After upgrading to -rc8 yesterday my powerbook started up today with the
>> > screen totally garbled, only occasionally was a word readable.
>> 
>> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
>> accelerate imageblit and other improvements").
>
> That's post -rc8, ok, but -rc7 worked fine here, and the stuff it
> reverts is all pre -rc7, no? Strange. I'll try later.

This appears to be a side effect of setting up info->pixmap in
radeon_set_fbinfo even if accel_cexp is 0.  Alternatively to the cited
patch you can also use something like this:

diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
index d5b27f9..532e2c5 100644
--- a/drivers/video/aty/radeon_base.c
+++ b/drivers/video/aty/radeon_base.c
@@ -1895,6 +1895,9 @@ static int __devinit radeon_set_fbinfo (struct radeonfb_info *rinfo)
 	/* Allocate colormap */
 	fb_alloc_cmap(&info->cmap, 256, 0);
 
+	if (!accel_cexp)
+		goto bail;
+
 	/* Setup pixmap used for acceleration */
 #define PIXMAP_SIZE	(2048 * 4)
 

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: powerbook VT garbled between rc7 and rc8

[Benjamin Herrenschmidt]

On Fri, 2008-12-12 at 16:00 +0100, Andreas Schwab wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote:
> >> Johannes Berg <johannes@sipsolutions.net> writes:
> >> 
> >> > After upgrading to -rc8 yesterday my powerbook started up today with the
> >> > screen totally garbled, only occasionally was a word readable.
> >> 
> >> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
> >> accelerate imageblit and other improvements").
> >
> > That's post -rc8, ok, but -rc7 worked fine here, and the stuff it
> > reverts is all pre -rc7, no? Strange. I'll try later.
> 
> This appears to be a side effect of setting up info->pixmap in
> radeon_set_fbinfo even if accel_cexp is 0.  Alternatively to the cited
> patch you can also use something like this:

Right but Linus just reverted the whole thing. Which is probably the way
to go. I'll try to fix the fbdev core itself one of these days, it's
seriously broken vs. handling of pitch in images.

Ben.

> diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
> index d5b27f9..532e2c5 100644
> --- a/drivers/video/aty/radeon_base.c
> +++ b/drivers/video/aty/radeon_base.c
> @@ -1895,6 +1895,9 @@ static int __devinit radeon_set_fbinfo (struct radeonfb_info *rinfo)
>  	/* Allocate colormap */
>  	fb_alloc_cmap(&info->cmap, 256, 0);
>  
> +	if (!accel_cexp)
> +		goto bail;
> +
>  	/* Setup pixmap used for acceleration */
>  #define PIXMAP_SIZE	(2048 * 4)
>  
> 
> Andreas.
> 

Re: powerbook VT garbled between rc7 and rc8

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

On Fri, 2008-12-12 at 13:05 +0100, Andreas Schwab wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > After upgrading to -rc8 yesterday my powerbook started up today with the
> > screen totally garbled, only occasionally was a word readable.
> 
> Try 6c34bc2976b30dc8b56392c020e25bae1f363cab (Revert "radeonfb:
> accelerate imageblit and other improvements").

I cherry-picked this and it works again, thanks!

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]