From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Trent Piepho <tpiepho@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: [PATCH 1/2] POWERPC/fsl-pci: Better ATMU setup
Date: Thu, 18 Dec 2008 07:59:11 +1100 [thread overview]
Message-ID: <1229547551.16253.39.camel@pasglop> (raw)
In-Reply-To: <1229543006-8950-1-git-send-email-tpiepho@freescale.com>
On Wed, 2008-12-17 at 11:43 -0800, Trent Piepho wrote:
The default ATMU window can support a pci_mem_offset less than zero too,
but pci_mem_offset is unsigned. One could say the abilities allowed a
powerpc pci_controller is neither subset nor a superset of the abilities of
a Freescale PCIe controller. Thankfully, the most useful bits are in the
intersection of the two abilities.
That sign issue shouldn't be too hard to fix if there's a real need by
making sure everything is unsigned and of the same width, in which case,
an addition with the unsigned pci_mem_offset will properly result in a
substraction of the later is negative, even when everybody is
unsigned :-)
But I don't see any pressing need for that.
Ben.
next prev parent reply other threads:[~2008-12-17 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 19:43 [PATCH 1/2] POWERPC/fsl-pci: Better ATMU setup Trent Piepho
2008-12-17 19:43 ` [PATCH 2/2] POWERPC/fsl-pci: Set relaxed ordering on prefetchable ranges Trent Piepho
2009-01-07 4:38 ` Kumar Gala
2008-12-17 20:59 ` Benjamin Herrenschmidt [this message]
2009-01-07 4:38 ` [PATCH 1/2] POWERPC/fsl-pci: Better ATMU setup Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229547551.16253.39.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tpiepho@freescale.com \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).