From: Michael Ellerman <michael@ellerman.id.au>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Paul Mackerras <paulus@samba.org>,
Milton Miller <miltonm@bga.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/3] powerpc: Make default kexec/crash_kernel ops implicit
Date: Mon, 22 Dec 2008 10:08:42 +1100 [thread overview]
Message-ID: <1229900922.8269.15.camel@localhost> (raw)
In-Reply-To: <20081216162305.GB21749@oksana.dev.rtsoft.ru>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Tue, 2008-12-16 at 19:23 +0300, Anton Vorontsov wrote:
> This patch removes need for each platform to specify default kexec and
> crash kernel ops, thus effectively adds a working kexec support for most
> boards.
>
> Platforms that can't cope with default ops will explode in some weird
> way (a hang or reboot is most likely), which means that the board's
> kexec support should be fixed or blacklisted via dummy _prepare callback
> returning -ENOSYS.
But where is the patch to do this?
The chance of kexec working on some random machine that's never been
tested is pretty slim, every driver needs to be aware its hardware might
be in a weird state, so enabling it by default is not a good idea IMHO.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-12-21 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 16:22 [PATCH 0/3] Kexec for PPC32 (6xx) machines Anton Vorontsov
2008-12-16 16:22 ` [PATCH 1/3] powerpc: Setup OF properties for ppc32 kexec Anton Vorontsov
2008-12-16 16:23 ` [PATCH 2/3] powerpc: Make default kexec/crash_kernel ops implicit Anton Vorontsov
2008-12-21 23:08 ` Michael Ellerman [this message]
2008-12-22 0:11 ` Anton Vorontsov
2008-12-23 0:15 ` Michael Ellerman
2008-12-16 16:23 ` [PATCH 3/3] powerpc: Remove default kexec/crash_kernel ops assignments Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229900922.8269.15.camel@localhost \
--to=michael@ellerman.id.au \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).