From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: linux-next: scsi-post-merge tree build failure
Date: Tue, 23 Dec 2008 07:56:32 +1100 [thread overview]
Message-ID: <1229979392.4360.15.camel@pasglop> (raw)
In-Reply-To: <20081223012545.5b1e7f5e.sfr@canb.auug.org.au>
On Tue, 2008-12-23 at 01:25 +1100, Stephen Rothwell wrote:
> Hi Paul, Ben,
>
> Today's linux-next build (powerpc ppc44x_config) failed like this:
>
> arch/powerpc/kvm/powerpc.c: In function 'kvm_arch_vcpu_put':
> arch/powerpc/kvm/powerpc.c:333: error: implicit declaration of function '_tlbil_all'
>
> Probably caused by commit 2a4aca1144394653269720ffbb5a325a77abd5fa
> ("powerpc/mm: Split low level tlb invalidate for nohash processors").
> Reverting just that commit was too difficult, so I have reverted the
> powerpc tree for today.
You can't revert that without reverting my whole series.
Adding a #include ../mm/mmu_decl.h to the kvm code should fix it for
now.
I need to talk to hollis about the right way to do that stuff in
the long run but it might be it... those _tlbil things are low level
stuff that aren't supposed to be used by the outside world which is
why I moved the declarations there, but KVM is also low level :-)
Cheers,
Ben.
next prev parent reply other threads:[~2008-12-22 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 14:25 linux-next: scsi-post-merge tree build failure Stephen Rothwell
2008-12-22 14:51 ` Stephen Rothwell
2008-12-22 20:56 ` Benjamin Herrenschmidt [this message]
2008-12-22 23:04 ` testing (Was: Re: linux-next: scsi-post-merge tree build failure) Stephen Rothwell
2008-12-23 0:19 ` Benjamin Herrenschmidt
2008-12-23 1:52 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1229979392.4360.15.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hollisb@us.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).