From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH RESEND] powerpc: make udbg 16550 boot console configurable for EMBEDDED
Date: Wed, 24 Dec 2008 07:19:56 +1100 [thread overview]
Message-ID: <1230063596.7292.3.camel@pasglop> (raw)
In-Reply-To: <1230037894-26837-1-git-send-email-jacmet@sunsite.dk>
On Tue, 2008-12-23 at 14:11 +0100, Peter Korsgaard wrote:
> The udbg console is currently always enabled for platforms selecting
> the PPC_UDBG_16550 symbol (needed to create platform devices for
> 8250 SoC UARTs from DT).
>
> Now, the udbg console is nice for debugging as it works so early, but
> it also has a number of disadvantages:
.../...
I don't think that's the right approach.
I think a better one is to make a config option that selects whether the
udbg console is registered. ie. CONFIG_UDBG_CONSOLE which would affect
the calls sites in setup_32/64.c or the register_udbg_console() function
itself in udbg.c
Ben.
prev parent reply other threads:[~2008-12-23 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 13:11 [PATCH RESEND] powerpc: make udbg 16550 boot console configurable for EMBEDDED Peter Korsgaard
2008-12-23 17:24 ` Scott Wood
2008-12-23 20:19 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230063596.7292.3.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jacmet@sunsite.dk \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).