From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B6F30DDDEF for ; Mon, 29 Dec 2008 12:25:59 +1100 (EST) Subject: Re: [PATCH] powerpc: Fix something From: Benjamin Herrenschmidt To: Paul Mackerras In-Reply-To: <18776.5641.616932.285903@cargo.ozlabs.ibm.com> References: <18776.5641.616932.285903@cargo.ozlabs.ibm.com> Content-Type: text/plain Date: Mon, 29 Dec 2008 12:25:50 +1100 Message-Id: <1230513950.15389.33.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2008-12-29 at 11:12 +1100, Paul Mackerras wrote: > X has been failing to start on my quad G5 powermac since commit > 1fd0f52583a85b21a394201b007bc1ee104b235d ("powerpc: Fix domain numbers > in /proc on 64-bit") went in. The reason is that the change allows X > to see the PCI-PCI bridge above the video card (previously it was > obscured by the fact that there were two "00" directories in > /proc/bus/pci), and the pciconfig_iobase system call on the bridge is > failing because of a hack that we have to return information about the > AGP bus when X asks about bus 0. This machine doesn't have an AGP bus > (it has PCI Express) and so the pciconfig_iobase call is returning -1, > which ultimately causes X to fail to start. > > This fixes it by checking that we have an AGP bridge before > redirecting the pciconfig_iobase call to return information about the > AGP bus. With this, X starts successfully both on a quad G5 with > PCI Express and on an older dual G5 with AGP. > > Signed-off-by: Paul Mackerras Acked-by: Benjamin Herrenschmidt --- (With fixed subject of course :-) Cheers, Ben.