* [PATCH] gianfar: ensure ECNTRL[R100] is cleared on link state change
@ 2009-01-06 20:52 Kumar Gala
2009-01-06 20:56 ` Andy Fleming
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2009-01-06 20:52 UTC (permalink / raw)
To: netdev; +Cc: Leo Li, linuxppc-dev, afleming, davem
From: Leo Li <leo@rock.ap.freescale.net>
When changing the link between 100Mbps and 1Gbps in SGMII mode it was
found out that the link would stop working. The issue is that ECNTRL[R100]
needs to be cleared when in 1Gbps mode. Older reference manuals didn't
require the explicitly clearing but has since been found it that it is
needed.
Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
Dave,
Please apply for 2.6.29 as it addresses a "HW" bug in real systems.
thanks
- k
drivers/net/gianfar.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index c672ecf..7fcc3af 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -1973,6 +1973,8 @@ static void adjust_link(struct net_device *dev)
case 1000:
tempval =
((tempval & ~(MACCFG2_IF)) | MACCFG2_GMII);
+
+ ecntrl &= ~(ECNTRL_R100);
break;
case 100:
case 10:
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gianfar: ensure ECNTRL[R100] is cleared on link state change
2009-01-06 20:52 [PATCH] gianfar: ensure ECNTRL[R100] is cleared on link state change Kumar Gala
@ 2009-01-06 20:56 ` Andy Fleming
2009-01-06 22:08 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andy Fleming @ 2009-01-06 20:56 UTC (permalink / raw)
To: Kumar Gala; +Cc: netdev, Leo Li, davem, linuxppc-dev
On Jan 6, 2009, at 2:52 PM, Kumar Gala wrote:
> From: Leo Li <leo@rock.ap.freescale.net>
>
> When changing the link between 100Mbps and 1Gbps in SGMII mode it was
> found out that the link would stop working. The issue is that
> ECNTRL[R100]
> needs to be cleared when in 1Gbps mode. Older reference manuals
> didn't
> require the explicitly clearing but has since been found it that it is
> needed.
>
> Signed-off-by: Li Yang <leoli@freescale.com>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Andy Fleming <afleming@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gianfar: ensure ECNTRL[R100] is cleared on link state change
2009-01-06 20:56 ` Andy Fleming
@ 2009-01-06 22:08 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-01-06 22:08 UTC (permalink / raw)
To: afleming; +Cc: netdev, leo, linuxppc-dev
From: Andy Fleming <afleming@freescale.com>
Date: Tue, 6 Jan 2009 14:56:25 -0600
>
> On Jan 6, 2009, at 2:52 PM, Kumar Gala wrote:
>
> > From: Leo Li <leo@rock.ap.freescale.net>
> >
> > When changing the link between 100Mbps and 1Gbps in SGMII mode it was
> > found out that the link would stop working. The issue is that ECNTRL[R100]
> > needs to be cleared when in 1Gbps mode. Older reference manuals didn't
> > require the explicitly clearing but has since been found it that it is
> > needed.
> >
> > Signed-off-by: Li Yang <leoli@freescale.com>
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>
> Acked-by: Andy Fleming <afleming@freescale.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-06 22:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-06 20:52 [PATCH] gianfar: ensure ECNTRL[R100] is cleared on link state change Kumar Gala
2009-01-06 20:56 ` Andy Fleming
2009-01-06 22:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).