From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Olof Johansson <olof@lixom.net>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] pasemi: ioremap/iounmap balance and failure handling
Date: Wed, 07 Jan 2009 11:50:55 +1100 [thread overview]
Message-ID: <1231289455.14860.46.camel@pasglop> (raw)
In-Reply-To: <49478879.2030409@gmail.com>
> +
> iob_regs = map_onedev(iob_pdev, 0);
> + if (iob_regs == NULL)
> + printk(KERN_WARNING "pasemi_dma_init: Can't ioremap I/O Bridge registers\n");
>
> dma_pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa007, NULL);
> if (!dma_pdev) {
> BUG();
> printk(KERN_WARNING "Can't find DMA controller\n");
> err = -ENODEV;
> - goto out;
> + goto out_unmap;
> }
None of that will be reached due to the previous BUG :-)
Cheers,
Ben.
prev parent reply other threads:[~2009-01-07 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 16:45 [PATCH] [POWERPC] pasemi: ioremap/iounmap balance and failure handling Roel Kluin
2008-12-13 19:15 ` Roel Kluin
2008-12-13 21:13 ` Olof Johansson
2008-12-16 10:52 ` Roel Kluin
2009-01-07 0:50 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231289455.14860.46.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).