linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ppc64: Enable RELOCATABLE option for CRASH_DUMP
@ 2009-01-02 17:55 M. Mohan Kumar
  0 siblings, 0 replies; 4+ messages in thread
From: M. Mohan Kumar @ 2009-01-02 17:55 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev

Enable RELOCATABLE option if user selects CRASH_DUMP option. Without this
patch user has to first select RELOCATABLE option and then has to enable
CRASH_DUMP option.

Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
 arch/powerpc/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 79f25ce..0cdce19 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -326,7 +326,8 @@ config KEXEC
 
 config CRASH_DUMP
 	bool "Build a kdump crash kernel"
-	depends on (PPC64 && RELOCATABLE) || 6xx
+	depends on PPC64 || 6xx
+	select RELOCATABLE
 	help
 	  Build a kernel suitable for use as a kdump capture kernel.
 	  The same kernel binary can be used as production kernel and dump
-- 
1.6.0.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ppc64: Enable RELOCATABLE option for CRASH_DUMP
@ 2009-01-05 13:28 Milton Miller
  2009-01-07  2:45 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 4+ messages in thread
From: Milton Miller @ 2009-01-05 13:28 UTC (permalink / raw)
  To: M. Mohan Kumar; +Cc: linux-ppc

Mohan wrote:

>  config CRASH_DUMP
>         bool "Build a kdump crash kernel"
> -       depends on (PPC64 && RELOCATABLE) || 6xx
> +       depends on PPC64 || 6xx
> +       select RELOCATABLE
>         help
>           Build a kernel suitable for use as a kdump capture kernel.
>           The same kernel binary can be used as production kernel and 
> dump
>

You should only select relocatable if ppc64

milton

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ppc64: Enable RELOCATABLE option for CRASH_DUMP
@ 2009-01-06 10:23 M. Mohan Kumar
  0 siblings, 0 replies; 4+ messages in thread
From: M. Mohan Kumar @ 2009-01-06 10:23 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Paul Mackerras; +Cc: linuxppc-dev, Milton Miller

Enable RELOCATABLE option if user selects CRASH_DUMP option. Without this
patch user has to first select RELOCATABLE option and then has to enable
CRASH_DUMP option.

Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
 arch/powerpc/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 79f25ce..acda551 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -326,7 +326,8 @@ config KEXEC
 
 config CRASH_DUMP
 	bool "Build a kdump crash kernel"
-	depends on (PPC64 && RELOCATABLE) || 6xx
+	depends on PPC64 || 6xx
+	select RELOCATABLE if PPC64
 	help
 	  Build a kernel suitable for use as a kdump capture kernel.
 	  The same kernel binary can be used as production kernel and dump
-- 
1.5.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ppc64: Enable RELOCATABLE option for CRASH_DUMP
  2009-01-05 13:28 [PATCH] ppc64: Enable RELOCATABLE option for CRASH_DUMP Milton Miller
@ 2009-01-07  2:45 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2009-01-07  2:45 UTC (permalink / raw)
  To: Milton Miller; +Cc: linux-ppc

On Mon, 2009-01-05 at 07:28 -0600, Milton Miller wrote:
> Mohan wrote:
> 
> >  config CRASH_DUMP
> >         bool "Build a kdump crash kernel"
> > -       depends on (PPC64 && RELOCATABLE) || 6xx
> > +       depends on PPC64 || 6xx
> > +       select RELOCATABLE
> >         help
> >           Build a kernel suitable for use as a kdump capture kernel.
> >           The same kernel binary can be used as production kernel and 
> > dump
> >
> 
> You should only select relocatable if ppc64

Please, can you try to conserve the mail IDs when you reply ? Not only
you break threads, but your replies never make it to patchwork which
makes it hard for me to know that you commented or acked/nacked a patch.

Thanks !

Cheers,
Ben.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-01-07  2:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-05 13:28 [PATCH] ppc64: Enable RELOCATABLE option for CRASH_DUMP Milton Miller
2009-01-07  2:45 ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2009-01-06 10:23 M. Mohan Kumar
2009-01-02 17:55 M. Mohan Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).