From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc/cell: fix the prototype of create_vma_map
Date: Wed, 07 Jan 2009 14:34:59 +1100 [thread overview]
Message-ID: <1231299299.14860.58.camel@pasglop> (raw)
In-Reply-To: <20090107105822.221c4395.sfr@canb.auug.org.au>
On Wed, 2009-01-07 at 10:58 +1100, Stephen Rothwell wrote:
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/powerpc/oprofile/cell/pr_util.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Arnd, I'm not too sure about this one, what do you think ? Shouldn't the
objectid be a u64 and the callers be fixed instead ?
Cheers,
Ben.
> diff --git a/arch/powerpc/oprofile/cell/pr_util.h b/arch/powerpc/oprofile/cell/pr_util.h
> index 628009c..dfdbffa 100644
> --- a/arch/powerpc/oprofile/cell/pr_util.h
> +++ b/arch/powerpc/oprofile/cell/pr_util.h
> @@ -79,7 +79,7 @@ struct spu_buffer {
> * the vma-to-fileoffset map.
> */
> struct vma_to_fileoffset_map *create_vma_map(const struct spu *spu,
> - u64 objectid);
> + unsigned long objectid);
> unsigned int vma_map_lookup(struct vma_to_fileoffset_map *map,
> unsigned int vma, const struct spu *aSpu,
> int *grd_val);
> --
> 1.6.0.5
>
next prev parent reply other threads:[~2009-01-07 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 23:58 [PATCH] powerpc/cell: fix the prototype of create_vma_map Stephen Rothwell
2009-01-07 3:34 ` Benjamin Herrenschmidt [this message]
2009-01-07 5:36 ` Stephen Rothwell
2009-01-07 19:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231299299.14860.58.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).