From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benh@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTPS id AC286DDF8F
	for <linuxppc-dev@ozlabs.org>; Wed,  7 Jan 2009 21:15:50 +1100 (EST)
Subject: Re: [PATCH/RFC] sysfs cache code rewrite
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Lynch <ntl@pobox.com>
In-Reply-To: <20090107094611.GD7376@localdomain>
References: <20081224045554.GA6958@localdomain>
	<20090106212533.GB7376@localdomain> <1231311102.14860.80.camel@pasglop>
	<1231311324.14860.81.camel@pasglop> <20090107094611.GD7376@localdomain>
Content-Type: text/plain
Date: Wed, 07 Jan 2009 21:15:44 +1100
Message-Id: <1231323344.14860.87.camel@pasglop>
Mime-Version: 1.0
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Wed, 2009-01-07 at 03:46 -0600, Nathan Lynch wrote:
> Benjamin Herrenschmidt wrote:
> > 
> > > I don't know quite the detail of the new cpumask stuff ... It could be
> > > as simple as passing a pointer instead of the value in the
> > > cpumask_scnprintf call though...
> > 
> > Actually, I'll do more tests and if that ends up being the only needed
> > change, I'll push your patch with that small change out to powerpc next
> > tonight.
> 
> Sorry about that, here's an incremental... let me know if you want the
> whole thing re-posted.

Nah, that's fine. I did that exact change in the patch before putting
in my tree. I haven't had a chance to test boot tho, did you ?

Cheers,
Ben.

> Thanks.
> 
> 
> diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c
> index f3e3ae3..b33f041 100644
> --- a/arch/powerpc/kernel/cacheinfo.c
> +++ b/arch/powerpc/kernel/cacheinfo.c
> @@ -611,7 +611,7 @@ static ssize_t shared_cpu_map_show(struct kobject *k, struct kobj_attribute *att
>  	len = PAGE_SIZE - 2;
>  
>  	if (len > 1) {
> -		n = cpumask_scnprintf(buf, len, cache->shared_cpu_map);
> +		n = cpumask_scnprintf(buf, len, &cache->shared_cpu_map);
>  		buf[n++] = '\n';
>  		buf[n] = '\0';
>  	}