* [PATCH] gianfar: Fixup use of BUS_ID_SIZE
@ 2009-01-07 15:52 Kumar Gala
2009-01-08 18:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2009-01-07 15:52 UTC (permalink / raw)
To: netdev; +Cc: linuxppc-dev, kay.sievers, afleming, davem
Commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 went back to using
BUS_ID_SIZE instead of sizeof() as per the larger patch series
that will remove "char bus_id[20]" from struct device.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/net/gianfar.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 7fcc3af..1b8deca 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -238,8 +238,8 @@ static int gfar_of_init(struct net_device *dev)
goto err_out;
}
- snprintf(priv->phy_bus_id, BUS_ID_SIZE, PHY_ID_FMT, "0",
- fixed_link[0]);
+ snprintf(priv->phy_bus_id, sizeof(priv->phy_bus_id),
+ PHY_ID_FMT, "0", fixed_link[0]);
} else {
phy = of_find_node_by_phandle(*ph);
@@ -256,7 +256,7 @@ static int gfar_of_init(struct net_device *dev)
of_node_put(mdio);
gfar_mdio_bus_name(bus_name, mdio);
- snprintf(priv->phy_bus_id, BUS_ID_SIZE, "%s:%02x",
+ snprintf(priv->phy_bus_id, sizeof(priv->phy_bus_id), "%s:%02x",
bus_name, *id);
}
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gianfar: Fixup use of BUS_ID_SIZE
2009-01-07 15:52 [PATCH] gianfar: Fixup use of BUS_ID_SIZE Kumar Gala
@ 2009-01-08 18:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-08 18:58 UTC (permalink / raw)
To: galak; +Cc: netdev, kay.sievers, afleming, linuxppc-dev
From: Kumar Gala <galak@kernel.crashing.org>
Date: Wed, 7 Jan 2009 09:52:01 -0600
> Commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 went back to using
> BUS_ID_SIZE instead of sizeof() as per the larger patch series
> that will remove "char bus_id[20]" from struct device.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Applied, thanks Kumar.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-08 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-07 15:52 [PATCH] gianfar: Fixup use of BUS_ID_SIZE Kumar Gala
2009-01-08 18:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).