Building current git for 405 is broken

Building current git for 405 is broken

[Matthias Fuchs]

Hi Benjamin,

commit 2a4aca114439 (powerpc/mm: Split low level tlb invalidate for nohash processors)
breaks building for 40x CPUs. This is what I get when building for the walnut board:

  CC      arch/powerpc/kernel/prom.o
In file included from arch/powerpc/kernel/prom.c:56:
arch/powerpc/mm/mmu_decl.h: In function '_tlbil_all':
arch/powerpc/mm/mmu_decl.h:34: error: expected ';' before '}' token
arch/powerpc/mm/mmu_decl.h:36: error: invalid storage class for function '_tlbil_pid'
arch/powerpc/mm/mmu_decl.h: In function '_tlbil_pid':
arch/powerpc/mm/mmu_decl.h:38: error: expected ';' before '}' token
arch/powerpc/mm/mmu_decl.h:53: warning: ISO C90 forbids mixed declarations and code
arch/powerpc/mm/mmu_decl.h:62: error: invalid storage class for function '_tlbivax_bcast'
arch/powerpc/kernel/prom.c:90: error: invalid storage class for function 'find_flat_dt_string'

Seems to be a result of some missing types or whatever. I suppose you are 
more familiar with that code than I am ;-)

Matthias

Re: Building current git for 405 is broken

[Josh Boyer]

On Wed, Jan 07, 2009 at 03:10:45PM +0100, Matthias Fuchs wrote:
>Hi Benjamin,
>
>commit 2a4aca114439 (powerpc/mm: Split low level tlb invalidate for nohash processors)
>breaks building for 40x CPUs. This is what I get when building for the walnut board:
>
>  CC      arch/powerpc/kernel/prom.o
>In file included from arch/powerpc/kernel/prom.c:56:
>arch/powerpc/mm/mmu_decl.h: In function '_tlbil_all':
>arch/powerpc/mm/mmu_decl.h:34: error: expected ';' before '}' token
>arch/powerpc/mm/mmu_decl.h:36: error: invalid storage class for function '_tlbil_pid'
>arch/powerpc/mm/mmu_decl.h: In function '_tlbil_pid':
>arch/powerpc/mm/mmu_decl.h:38: error: expected ';' before '}' token
>arch/powerpc/mm/mmu_decl.h:53: warning: ISO C90 forbids mixed declarations and code
>arch/powerpc/mm/mmu_decl.h:62: error: invalid storage class for function '_tlbivax_bcast'
>arch/powerpc/kernel/prom.c:90: error: invalid storage class for function 'find_flat_dt_string'
>
>Seems to be a result of some missing types or whatever. I suppose you are 
>more familiar with that code than I am ;-)

He sent a patch to fix this last night.

josh

Re: Building current git for 405 is broken

[Kumar Gala]

On Jan 7, 2009, at 8:10 AM, Matthias Fuchs wrote:

> Hi Benjamin,
>
> commit 2a4aca114439 (powerpc/mm: Split low level tlb invalidate for  
> nohash processors)
> breaks building for 40x CPUs. This is what I get when building for  
> the walnut board:
>
>  CC      arch/powerpc/kernel/prom.o
> In file included from arch/powerpc/kernel/prom.c:56:
> arch/powerpc/mm/mmu_decl.h: In function '_tlbil_all':
> arch/powerpc/mm/mmu_decl.h:34: error: expected ';' before '}' token
> arch/powerpc/mm/mmu_decl.h:36: error: invalid storage class for  
> function '_tlbil_pid'
> arch/powerpc/mm/mmu_decl.h: In function '_tlbil_pid':
> arch/powerpc/mm/mmu_decl.h:38: error: expected ';' before '}' token
> arch/powerpc/mm/mmu_decl.h:53: warning: ISO C90 forbids mixed  
> declarations and code
> arch/powerpc/mm/mmu_decl.h:62: error: invalid storage class for  
> function '_tlbivax_bcast'
> arch/powerpc/kernel/prom.c:90: error: invalid storage class for  
> function 'find_flat_dt_string'
>
> Seems to be a result of some missing types or whatever. I suppose  
> you are
> more familiar with that code than I am ;-)

Ben posted a patch that might address the issue:

http://patchwork.ozlabs.org/patch/17037/

- k

Re: Building current git for 405 is broken

[Benjamin Herrenschmidt]

On Wed, 2009-01-07 at 15:10 +0100, Matthias Fuchs wrote:
> Hi Benjamin,
> 
> commit 2a4aca114439 (powerpc/mm: Split low level tlb invalidate for nohash processors)
> breaks building for 40x CPUs. This is what I get when building for the walnut board:

The fix is in my tree, I'll push it out and ask Linus to pull later
today or tomorrow.

Cheers,
Ben.