From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Milton Miller <miltonm@us.ibm.com>,
Joe Peterson <joe@skyrush.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [BUG] hvc_console WARN() on current upstream
Date: Thu, 08 Jan 2009 19:42:01 +1100 [thread overview]
Message-ID: <1231404121.2142.50.camel@pasglop> (raw)
In-Reply-To: <200901080857.44090.borntraeger@de.ibm.com>
Also including Alan, he's the current tty guru
On Thu, 2009-01-08 at 08:57 +0100, Christian Borntraeger wrote:
> Am Donnerstag, 8. Januar 2009 schrieb Benjamin Herrenschmidt:
> > ------------[ cut here ]------------
> > Badness at /home/benh/kernels/linux-powerpc/kernel/mutex.c:135
> > NIP: c0000000004fe0dc LR: c0000000004fe0c0 CTR: c0000000002c4304
> > REGS: c00000000fffb660 TRAP: 0700 Not tainted (2.6.28-test)
> > MSR: 8000000000021032 <ME,CE,IR,DR> CR: 28000082 XER: 20000003
> > TASK = c0000000007bd340[0] 'swapper' THREAD: c000000000874000 CPU: 0
> > GPR00: 0000000000000000 c00000000fffb8e0 c000000000877438 0000000000000001
> > GPR04: 0000000000000000 c0000000225f0928 0000000000000003 0000000008000001
> > GPR08: cf3cf3cf3cf3cf3d c000000000e6edc0 c000000000787634 c0000000008d45ac
> > GPR12: 0000000028000082 c0000000008b7300 c00000002254db20 0000000000000001
> > GPR16: 0000000000000003 c00000002254d940 c00000002254da70 c0000000225f0828
> > GPR20: c0000000225f0929 0000000000000000 c00000002254dee8 0000000000000000
> > GPR24: 0000000000000000 c0000000002c2604 0000000000000003 c0000000007bd340
> > GPR28: c00000002254dee8 c00000002254d800 c0000000007ef2b8 c00000002254dee8
> > NIP [c0000000004fe0dc] .mutex_lock_nested+0x90/0x408
> > LR [c0000000004fe0c0] .mutex_lock_nested+0x74/0x408
> > Call Trace:
> > [c00000000fffb9e0] [c0000000002c2604] .echo_set_canon_col+0x28/0x68
> > [c00000000fffba70] [c0000000002c4db4] .n_tty_receive_buf+0xcbc/0xfe0
> > [c00000000fffbc10] [c0000000002c80f8] .flush_to_ldisc+0x18c/0x24c
> > [c00000000fffbcd0] [c0000000002dd02c] .hvc_poll+0x2d0/0x328
> > [c00000000fffbde0] [c0000000002dd2e4] .hvc_handle_interrupt+0x14/0x3c
> > [c00000000fffbe50] [c0000000000999a4] .handle_IRQ_event+0x50/0xc0
> > [c00000000fffbef0] [c00000000009bdec] .handle_fasteoi_irq+0xf8/0x194
> > [c00000000fffbf90] [c000000000025950] .call_handle_irq+0x1c/0x2c
> > [c000000000877a30] [c00000000000cd18] .do_IRQ+0x104/0x1dc
> > [c000000000877ae0] [c000000000004800] hardware_interrupt_entry+0x18/0x98
> > --- Exception: 501 at .cpu_idle+0x104/0x190
> > LR = .cpu_idle+0x104/0x190
> > [c000000000877dd0] [c000000000011e58] .cpu_idle+0xf8/0x190 (unreliable)
> > [c000000000877e60] [c000000000500b24] .rest_init+0x7c/0x94
> > [c000000000877ee0] [c000000000715aec] .start_kernel+0x3f4/0x414
> > [c000000000877f90] [c000000000008368] .start_here_common+0x1c/0x34
> > Instruction dump:
> > 78290464 80090014 5409012f 41820028 4bd5ead5 60000000 2fa30000 419e0018
> > e93e8008 80090000 2f800000 409e0008 <0fe00000> 38000000 8b8d01da 980d01da
> >
> > The machine still boots, so it's not a show stopper.
>
>
> Hmmm,
>
> Seems that we are in interrupt, doing hvc_poll, which does
> tty_flip_buffer_push
> which calls
> flush_to_ldisc
> doing a
> n_tty_receive_buf
> and we will finally take a mutex in echo_set_canon_col
>
> my first guess is that the following patch triggered the Badness:
> git show a88a69c9
> commit a88a69c91256418c5907c2f1f8a0ec0a36f9e6cc
> Author: Joe Peterson <joe@skyrush.com>
> Date: Fri Jan 2 13:40:53 2009 +0000
>
> n_tty: Fix loss of echoed characters and remove bkl from n_tty
>
>
> I have no idea how to fix this.
> Joe Peterson CCed.
>
> Christian
>
next prev parent reply other threads:[~2009-01-08 8:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 5:18 [BUG] hvc_console WARN() on current upstream Benjamin Herrenschmidt
2009-01-08 7:57 ` Christian Borntraeger
2009-01-08 8:42 ` Benjamin Herrenschmidt [this message]
2009-01-08 11:11 ` Alan Cox
2009-01-08 12:12 ` [PATCH 0/5] hvc_console updates was " Milton Miller
2009-01-08 12:14 ` [PATCH 4/4] hvc_console: comment mb and make it an smp_ one Milton Miller
2009-01-08 12:14 ` [PATCH 3/4] hvc_console: free_irq only if request_irq was successful Milton Miller
2009-01-08 16:50 ` Christian Borntraeger
2009-01-08 12:14 ` [PATCH 1/4] hvc_console: do not set low_latency Milton Miller
2009-01-08 12:36 ` Alan Cox
2009-01-08 13:25 ` Milton Miller
2009-01-13 9:04 ` Christian Borntraeger
2009-01-13 11:28 ` Christian Borntraeger
2009-01-13 11:35 ` Hendrik Brueckner
2009-01-13 16:03 ` Milton Miller
2009-01-13 21:04 ` Benjamin Herrenschmidt
2009-01-15 9:15 ` [PATCH 1/4 v2] hvc_console: remove tty->low_latency Hendrik Brueckner
2009-01-15 9:17 ` Christian Borntraeger
2009-01-08 12:14 ` [PATCH 2/4] hvc_console: use kzalloc Milton Miller
2009-01-08 20:36 ` [BUG] hvc_console WARN() on current upstream Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231404121.2142.50.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=borntraeger@de.ibm.com \
--cc=joe@skyrush.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).