From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Joe Peterson <joe@skyrush.com>,
Milton Miller <miltonm@us.ibm.com>
Subject: Re: [BUG] hvc_console WARN() on current upstream
Date: Fri, 09 Jan 2009 07:36:12 +1100 [thread overview]
Message-ID: <1231446972.2142.55.camel@pasglop> (raw)
In-Reply-To: <20090108111116.3f806d67@lxorguk.ukuu.org.uk>
On Thu, 2009-01-08 at 11:11 +0000, Alan Cox wrote:
> > > Seems that we are in interrupt, doing hvc_poll, which does
> > > tty_flip_buffer_push
>
> Which means that someone has tty->low_latency set and is calling
> tty_flip_buffer_push in an IRQ. That has never been allowed or safe, and
> now it hurts ;)
Heh, allright :-) I'll see where that flag is set and clear it when
using IRQs.
> That comment has been there for some years in varying formats
Possibly, I didn't write that code, thanks for pointing me to the
problem.
Cheers,
Ben.
prev parent reply other threads:[~2009-01-08 20:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 5:18 [BUG] hvc_console WARN() on current upstream Benjamin Herrenschmidt
2009-01-08 7:57 ` Christian Borntraeger
2009-01-08 8:42 ` Benjamin Herrenschmidt
2009-01-08 11:11 ` Alan Cox
2009-01-08 12:12 ` [PATCH 0/5] hvc_console updates was " Milton Miller
2009-01-08 12:14 ` [PATCH 4/4] hvc_console: comment mb and make it an smp_ one Milton Miller
2009-01-08 12:14 ` [PATCH 3/4] hvc_console: free_irq only if request_irq was successful Milton Miller
2009-01-08 16:50 ` Christian Borntraeger
2009-01-08 12:14 ` [PATCH 1/4] hvc_console: do not set low_latency Milton Miller
2009-01-08 12:36 ` Alan Cox
2009-01-08 13:25 ` Milton Miller
2009-01-13 9:04 ` Christian Borntraeger
2009-01-13 11:28 ` Christian Borntraeger
2009-01-13 11:35 ` Hendrik Brueckner
2009-01-13 16:03 ` Milton Miller
2009-01-13 21:04 ` Benjamin Herrenschmidt
2009-01-15 9:15 ` [PATCH 1/4 v2] hvc_console: remove tty->low_latency Hendrik Brueckner
2009-01-15 9:17 ` Christian Borntraeger
2009-01-08 12:14 ` [PATCH 2/4] hvc_console: use kzalloc Milton Miller
2009-01-08 20:36 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231446972.2142.55.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=borntraeger@de.ibm.com \
--cc=joe@skyrush.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).