From: Carl Love <cel@us.ibm.com>
To: Robert Richter <robert.richter@amd.com>
Cc: linuxppc-dev@ozlabs.org, cel <cel@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
oprofile-list@lists.sourceforge.net,
cbe-oss-dev <cbe-oss-dev@ozlabs.org>
Subject: Re: [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor
Date: Thu, 08 Jan 2009 16:26:31 -0800 [thread overview]
Message-ID: <1231460791.6621.54.camel@carll-linux-desktop> (raw)
In-Reply-To: <20090108154835.GQ15411@erda.amd.com>
On Thu, 2009-01-08 at 16:48 +0100, Robert Richter wrote:
> On 01.12.08 16:18:26, Carl Love wrote:
> > This is a rework of the previously posted set of patches.
> >
> > Patch 1 is the user level patch to add the SPU events to the user
> > OProfile tool.
> >
> > Patch 2 is a kernel patch to do code clean up and restructuring to make
> > it easier to add the new SPU event profiling support. This patch makes
> > no functional changes.
> >
> > Patch 3 is a kernel patch to add the SPU event profiling support.
>
> I applied patch 2 & 3 to:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git cell
>
> The patches did not apply cleanly. I had to change the path to
> arch/powerpc/include/asm/, fix cell/pr_util.h and did some whitespace
> cleanups. Please run your tests on the cell branch.
>
> Thanks,
>
> -Robert
>
I pulled down the git tree, compiled and installed it. I tested it
against the OProfile testsuite, which includes SPU event profiling
tests. Everything passed. The patch I submitted was against a 2.6.26
tree. You are now on a 2.6.28 tree so perhaps that is why the patch did
not apply cleanly. The patch has been out there for some time.
Carl Love
next prev parent reply other threads:[~2009-01-09 0:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 0:18 [Patch 0/3] Overview, OProfile SPU event profiling support for IBM Cell processor Carl Love
2009-01-08 15:48 ` Robert Richter
2009-01-09 0:26 ` Carl Love [this message]
2009-01-09 14:30 ` Robert Richter
2009-01-10 23:31 ` Benjamin Herrenschmidt
2009-01-12 16:15 ` Carl Love
2009-01-12 17:52 ` Robert Richter
2009-01-12 17:59 ` Arnd Bergmann
2009-01-12 18:10 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231460791.6621.54.camel@carll-linux-desktop \
--to=cel@us.ibm.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cel@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox