From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/5] powerpc: Add platform support for AmigaOne
Date: Mon, 12 Jan 2009 16:08:07 +1100 [thread overview]
Message-ID: <1231736887.22571.18.camel@pasglop> (raw)
In-Reply-To: <20090107190718.GA17427@ld0162-tx32.am.freescale.net>
> > + /* Flush and disable I/D cache. */
> > + __asm__ __volatile__ ("mfspr 3, 1008" ::: "r3");
> > + __asm__ __volatile__ ("ori 5, 5, 0xcc00" ::: "r5");
> > + __asm__ __volatile__ ("ori 4, 3, 0xc00" ::: "r4");
> > + __asm__ __volatile__ ("andc 5, 3, 5" ::: "r5");
>
> Don't do this; instead, have one multi-line asm statement (or better yet,
> just use mfspr()/mtspr()/sync()/isync()).
>
> GCC is perfectly free to trash your registers in between statements.
Also there's already some code around to properly flush & disable the
caches on those processors.
Ben.
next prev parent reply other threads:[~2009-01-12 5:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 13:54 [PATCH 1/5] powerpc: Add platform support for AmigaOne Gerhard Pircher
2009-01-07 14:01 ` [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-07 16:41 ` Grant Likely
2009-01-07 22:10 ` Scott Wood
2009-01-07 22:21 ` Grant Likely
2009-01-07 22:23 ` Scott Wood
2009-01-07 22:36 ` Grant Likely
2009-01-07 22:38 ` Scott Wood
2009-01-12 5:07 ` Benjamin Herrenschmidt
2009-01-12 5:58 ` Grant Likely
2009-01-07 14:03 ` [PATCH 3/5] powerpc: Bootwrapper and serial console support for AmigaOne Gerhard Pircher
2009-01-07 15:07 ` Grant Likely
2009-01-07 15:20 ` Gerhard Pircher
2009-01-07 15:47 ` Grant Likely
2009-01-07 14:05 ` [PATCH 4/5] powerpc: Default config for AmigaOne boards Gerhard Pircher
2009-01-07 14:12 ` [PATCH 5/5] ide: Force VIA IDE legacy interrupts " Gerhard Pircher
2009-01-07 15:13 ` Grant Likely
2009-01-07 15:27 ` Gerhard Pircher
2009-01-11 16:51 ` Bartlomiej Zolnierkiewicz
2009-01-11 20:05 ` Gerhard Pircher
2009-01-12 17:55 ` Bartlomiej Zolnierkiewicz
2009-01-07 16:07 ` [PATCH 1/5] powerpc: Add platform support for AmigaOne Grant Likely
2009-01-07 19:07 ` Scott Wood
2009-01-07 22:50 ` [PATCH 2/5] powerpc: Generic device tree for all AmigaOne boards Gerhard Pircher
2009-01-12 5:12 ` Benjamin Herrenschmidt
2009-01-12 23:39 ` [PATCH 1/5] powerpc: Add platform support for AmigaOne Gerhard Pircher
2009-01-12 5:08 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 22:50 Gerhard Pircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231736887.22571.18.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).