From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <kumar.gala@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Andrew Klossner <andrew@cesa.opbu.xerox.com>
Subject: Re: [PATCH] Restore PCI IO space behind Freescale pseudo-bridge
Date: Wed, 28 Jan 2009 20:31:12 +1100 [thread overview]
Message-ID: <1233135072.6963.34.camel@pasglop> (raw)
In-Reply-To: <E601679F-F6E5-4DE0-A6AB-B7191F496C49@freescale.com>
> > We are using the patch I emailed. It's ugly in that it hard-codes the
> > Freescale vendor ID, but it works for us.
>
> I guess I'm confused what the actual breakage is beyond some printk
> messages.
>
> We "fixup" the resources in fsl_pcibios_fixup_bus() so Ben's change
> shouldn't have an impact. Does something actually stop functioning?
I think the problem comes from my patch that "detects" closed bridge
windows, which uses the PCI_COMMAND register as a clue, and it seems
that your bridges don't properly support IO enable in there..
Ben.
next prev parent reply other threads:[~2009-01-28 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901271813.n0RIDBHq023872@pogo.cesa.opbu.xerox.com>
2009-01-28 5:37 ` [PATCH] Restore PCI IO space behind Freescale pseudo-bridge Kumar Gala
2009-01-28 9:31 ` Benjamin Herrenschmidt [this message]
2009-01-28 15:59 ` Kumar Gala
2009-01-14 19:48 Andrew Klossner
2009-01-14 20:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233135072.6963.34.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=andrew@cesa.opbu.xerox.com \
--cc=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).