Re: [PATCH] AMCC Crypto4xx Device Driver v5

[James Hsiao <jhsiao@amcc.com>]

Hi Herbert,

I will re submit the patch with proper changelog.
I had the change log this way is for the reviewer easy to see the
difference. But, I agree this is not proper for a newly created driver.

Thanks
James 
On Wed, 2009-01-28 at 14:59 +1100, Herbert Xu wrote:
> On Mon, Jan 12, 2009 at 11:30:50AM -0800, James Hsiao wrote:
> > This is the 5th submission of AMCC's security driver.
> > - remove aad support in build pd function, since we didn't release any
> > algorithm that use aead yet.
> > 
> > - changed some hardcode value to #defines
> > 
> > - changed local_irq_disable/enable to spinlock_irq_save/restore
> > 
> > - fixed bug in crypto4xx_probe on error exit.
> > 
> > 
> > Signed-off-by: James Hsiao <jhsiao@amcc.com>
> 
> I was going to apply this but you didn't give me a changelog
> that I can throw into the tree without feeling guilty!
> 
> Please always attach a proper changelog with each submission
> so I don't have to do this.  You can put the changelog elsewhere
> in the email.
> 
> Thanks,