linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dave Airlie <airlied@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	linuxppc-dev@ozlabs.org, dri-devel@lists.sf.net
Subject: Re: [PATCH 1/3] drm: Use resource_size_t for drm_get_resource_{start,  len}
Date: Tue, 03 Feb 2009 07:36:28 +1100	[thread overview]
Message-ID: <1233606988.18767.98.camel@pasglop> (raw)
In-Reply-To: <21d7e9970902020508y77384e5ak4d348decb536e887@mail.gmail.com>

>    2009-02-02 14:16:04.000000000 +1100
> > @@ -599,8 +599,8 @@ int savage_driver_firstopen(struct drm_d
> >                            drm_mtrr_add(dev_priv->mtrr[2].base,
> >                                         dev_priv->mtrr[2].size, DRM_MTRR_WC);
> >                } else {
> > -                       DRM_ERROR("strange pci_resource_len %08lx\n",
> > -                                 drm_get_resource_len(dev, 0));
> > +                       DRM_ERROR("strange pci_resource_len %08llx\n",
> > +                                 (unsigned long long)drm_get_resource_len(dev, 0));
> 
> Don't we have a printk specifier for this now?

If we do I've missed it. We have a specifier for a struct resource *,
but not for an individual resource_size_t afaik.

Cheers,
Ben.

  reply	other threads:[~2009-02-02 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02  5:55 [PATCH 1/3] drm: Use resource_size_t for drm_get_resource_{start, len} Benjamin Herrenschmidt
2009-02-02 13:08 ` Dave Airlie
2009-02-02 20:36   ` Benjamin Herrenschmidt [this message]
2009-02-02 19:02 ` Eric Anholt
2009-02-02 20:37   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233606988.18767.98.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=airlied@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.sf.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).