From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH v2 1/4] Add platform support for AmigaOne
Date: Wed, 04 Feb 2009 14:50:07 +1100 [thread overview]
Message-ID: <1233719407.16867.164.camel@pasglop> (raw)
In-Reply-To: <20090202213910.258290@gmx.net>
> + hose->first_busno = bus_range ? bus_range[0] : 0;
> + hose->last_busno = bus_range ? bus_range[1] : 0xff;
> +
> + setup_indirect_pci(hose, 0xfec00cf8, 0xfee00cfc, 0);
Minor in the context of amigaone but still... the above should come from
the device-tree... I suppose those are really just IO space addresses
cf8 and cfc, in which case, an option is to call that first:
> + /* Interpret the "ranges" property */
> + /* This also maps the I/O region and sets isa_io/mem_base */
> + pci_process_bridge_OF_ranges(hose, dev, 1);
And -then- use hose->io_resource.start + 0xcf8 / 0xcfc, the later can be
hard coded as they are pretty standard values.
Ben.
next prev parent reply other threads:[~2009-02-04 3:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:21 AmigaOne platform patches v2 Gerhard Pircher
2009-02-02 21:39 ` [PATCH v2 1/4] Add platform support for AmigaOne Gerhard Pircher
2009-02-04 3:50 ` Benjamin Herrenschmidt [this message]
2009-02-04 12:09 ` Gerhard Pircher
2009-02-04 20:47 ` Benjamin Herrenschmidt
2009-02-05 13:36 ` [RFC] Error handling in *_add/find_bridges() Gerhard Pircher
2009-02-04 20:59 ` [PATCH v2 1/4] Add platform support for AmigaOne Gabriel Paubert
2009-02-04 21:35 ` Gerhard Pircher
2009-02-04 21:39 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233719407.16867.164.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=gerhard_pircher@gmx.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).