From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <benh@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTPS id F23B3DDEFB
	for <linuxppc-dev@ozlabs.org>; Wed,  4 Feb 2009 15:17:54 +1100 (EST)
Subject: Re: [PATCH v2] Check name property to determine partition nodes.
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Benjamin Krill <ben@codiert.org>
In-Reply-To: <20090123161805.GA2598@codiert.org>
References: <20090123161805.GA2598@codiert.org>
Content-Type: text/plain
Date: Wed, 04 Feb 2009 15:09:02 +1100
Message-Id: <1233720542.16867.187.camel@pasglop>
Mime-Version: 1.0
Cc: linuxppc-dev@ozlabs.org, vwool@ru.mvista.com, linux-mtd@lists.infradead.org,
	David Woodhouse <dwmw2@infradead.org>, dwg@au1.ibm.com
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote:
> SLOF has a further node which could not be evaluate
> by the current routine. The current routine returns
> because the node hasn't the required reg property. As
> fix this patch adds a check to determine the partition
> child nodes. If the node is not an partition the number
> of total partitions will be decreased and loop continue
> with the next nodes.

Somebody on the MTD list is taking that ? David ? Or should I merge it
via powerpc ?

Cheers,
Ben.

> Signed-off-by: Benjamin Krill <ben@codiert.org>
> ---
>  drivers/mtd/ofpart.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 9e45b3f..3e164f0 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -46,6 +46,13 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
>  		const u32 *reg;
>  		int len;
>  
> +		/* check if this is a partition node */
> +		partname = of_get_property(pp, "name", &len);
> +		if (strcmp(partname, "partition") != 0) {
> +			nr_parts--;
> +			continue;
> +		}
> +
>  		reg = of_get_property(pp, "reg", &len);
>  		if (!reg || (len != 2 * sizeof(u32))) {
>  			of_node_put(pp);