From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Octavian Purdila <opurdila@ixiacom.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc: G4 oprofile: variable number of counters
Date: Wed, 04 Feb 2009 16:22:14 +1100 [thread overview]
Message-ID: <1233724934.16867.290.camel@pasglop> (raw)
In-Reply-To: <1231246535-13151-2-git-send-email-opurdila@ixiacom.com>
On Tue, 2009-01-06 at 14:55 +0200, Octavian Purdila wrote:
> For ppc750 processors which use 4 performance counters instead of the
> 6 G4 uses but otherwise is compatible with G4.
>
> Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
> ---
> arch/powerpc/oprofile/op_model_7450.c | 21 +++++++++++----------
> 1 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/arch/powerpc/oprofile/op_model_7450.c b/arch/powerpc/oprofile/op_model_7450.c
> index cc599eb..97348f5 100644
> --- a/arch/powerpc/oprofile/op_model_7450.c
> +++ b/arch/powerpc/oprofile/op_model_7450.c
> @@ -29,7 +29,7 @@
> static unsigned long reset_value[OP_MAX_COUNTER];
>
> static int oprofile_running;
> -static u32 mmcr0_val, mmcr1_val, mmcr2_val;
> +static u32 mmcr0_val, mmcr1_val, mmcr2_val, ctrs;
This may be static but it's still a global scope as far as kernel
symbols are concerned. Care to give it a slightly better name ? num_pmcs
would probably be already more telling.
Cheers,
Ben.
next prev parent reply other threads:[~2009-02-04 5:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 12:55 [PATCH 0/2] oprofile support for ppc750 Octavian Purdila
2009-01-06 12:55 ` [PATCH 1/2] powerpc: G4 oprofile: variable number of counters Octavian Purdila
2009-02-04 5:22 ` Benjamin Herrenschmidt [this message]
2009-02-24 12:09 ` Octavian Purdila
2009-02-24 12:09 ` [PATCH v2 " Octavian Purdila
2009-02-24 12:09 ` [PATCH v2 2/2] powerpc: oprofile: enable support for ppc750 processors Octavian Purdila
2009-02-26 22:30 ` Andy Fleming
2009-02-26 23:13 ` Benjamin Herrenschmidt
2009-02-27 11:57 ` Octavian Purdila
2009-01-06 12:55 ` [PATCH " Octavian Purdila
2009-03-04 4:47 ` Benjamin Herrenschmidt
2009-03-04 12:02 ` Octavian Purdila
2009-01-07 2:52 ` [PATCH 0/2] oprofile support for ppc750 Benjamin Herrenschmidt
2009-01-07 12:17 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233724934.16867.290.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).