From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4023DDDDA1 for ; Tue, 10 Feb 2009 09:22:45 +1100 (EST) Subject: Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC From: Benjamin Herrenschmidt To: Ingo Molnar In-Reply-To: <20090209094014.GE7930@elte.hu> References: <20090209094014.GE7930@elte.hu> Content-Type: text/plain Date: Tue, 10 Feb 2009 09:21:59 +1100 Message-Id: <1234218119.31963.109.camel@pasglop> Mime-Version: 1.0 Cc: Arnd Bergmann , LKML , Steven Rostedt , linuxppc-dev@ozlabs.org, Paul Mackerras , Remis Lima Baima List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2009-02-09 at 10:40 +0100, Ingo Molnar wrote: > * Steven Rostedt wrote: > > > > > Paul, > > > > I found the bug that was causing large modules to fail in setting > > up dynamic ftrace. It wound up being a simple math error. To calculate > > the offset in the TOC, I had used an OR, but the bottom half was > > a signed extended short, and it should have been an addition. > > The fix is in my tree below, as well as posted here. > > Looks like a .29 candidate? Yup, I was planning to send it to Linus along with a handful of other powerpc fixes today, unless you prefer taking it yourself. Cheers, Ben.